-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use JWT and basic authorization in 1.28 #31468
Comments
In the logs I can see the
This is not happening with Envoy 1.27:
The regression has been introduced in #28678 |
cc @yanavlasov |
I think this could be fixed by avoid using |
Hi, I'm interested in contributing a fix for this. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
Not stale |
Duplicated headers should not be concatenated with a comma, because comma is not allowed in a JWT token, so concatenation invalidates tokens. This PR fixes #31468. Risk Level: Testing: unit tests Docs Changes: none Release Notes: Platform Specific Features: none Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Duplicated headers should not be concatenated with a comma, because comma is not allowed in a JWT token, so concatenation invalidates tokens. This PR fixes envoyproxy#31468. Risk Level: Testing: unit tests Docs Changes: none Release Notes: Platform Specific Features: none Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Duplicated headers should not be concatenated with a comma, because comma is not allowed in a JWT token, so concatenation invalidates tokens. This PR fixes envoyproxy#31468. Risk Level: Testing: unit tests Docs Changes: none Release Notes: Platform Specific Features: none Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Duplicated headers should not be concatenated with a comma, because comma is not allowed in a JWT token, so concatenation invalidates tokens. This PR fixes #31468. Risk Level: Testing: unit tests Docs Changes: none Release Notes: Platform Specific Features: none Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Duplicated headers should not be concatenated with a comma, because comma is not allowed in a JWT token, so concatenation invalidates tokens. This PR fixes #31468. Risk Level: Testing: unit tests Docs Changes: none Release Notes: Platform Specific Features: none Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Duplicated headers should not be concatenated with a comma, because comma is not allowed in a JWT token, so concatenation invalidates tokens. This PR fixes envoyproxy#31468. Risk Level: Testing: unit tests Docs Changes: none Release Notes: Platform Specific Features: none Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
As of Envoy 1.28 it is not possible to use the JWT authorization header together with another authorization type, such as basic authentication.
Envoy v1.28.0:
Envoy v1.27.2:
Configuration
Get
demo.jwt
from https://github.com/istio/istio/blob/master/security/tools/jwt/samples/demo.jwtThe text was updated successfully, but these errors were encountered: