[Debug]: improved debug msg instead of [object Object] #7337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance Report for 2ade689 Relationship Analysis |
|
Asset Size Report for 2ade689 IE11 Builds EmberData increased by 2.0 B (-35.0 B compressed) which is within the allowed tolerance of 15 bytes uncompressedWarningsThe uncompressed size of the package @ember-data/store has increased by 2.0 B. Changeset Full Asset Analysis (IE11)Modern Builds EmberData increased by 2.0 B (-35.0 B compressed) which is within the allowed tolerance of 15 bytes uncompressedWarningsThe uncompressed size of the package @ember-data/store has increased by 2.0 B. Changeset Full Asset Analysis (Modern)Modern Builds (No Rollup) EmberData increased by 2.0 B (-16.0 B compressed) which is within the allowed tolerance of 15 bytes uncompressedWarningsThe uncompressed size of the package @ember-data/store has increased by 2.0 B. Changeset Full Asset Analysis (Modern) |
igorT
reviewed
Sep 27, 2020
| throw new Error( | ||
| `Failed to update the 'id' for the RecordIdentifier '${identifier}' to '${resourceData.id}', because that id is already in use by '${matchedIdentifier}'` | ||
| `Failed to update the 'id' for the RecordIdentifier '${identifier}' to '${resourceData.id}', because that id is already in use by ${type}:${id} (${lid})` |
There was a problem hiding this comment.
Should we do this for the '${identifier}' as well?
igorT
reviewed
Sep 29, 2020
| @@ -79,4 +79,71 @@ module('Integration | Identifiers - cache', function(hooks) { | |||
| ); | |||
| }); | |||
| }); | |||
|
|
|||
| module('createIdentifierForNewRecord()', function() { | |||
There was a problem hiding this comment.
In general it would be great so split modules into new files
igorT
reviewed
Sep 29, 2020
| let existingIdentifier = detectMerge(this._cache.types, identifier, data, newId, this._cache.lids); | ||
|
|
||
| if (existingIdentifier) { | ||
| const keyOptions = getTypeIndex(this._cache.types, identifier.type); |
There was a problem hiding this comment.
While you are cleaning up, it would be great to not have this const here, as we do a let keyOptions on line 357
Merged
|
I cherry-picked the debug message commits into #7342 to not block merging on the other cleanup review |
662bb8d to
f184cc7
Compare
|
@snewcomer wanna rebase against master, and I'll merge |
update identifier as well Add tests for cache methods add moar tests cannot assert debug errors in prod tests address feedback
0efbde8 to
2ade689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7193