[Test]: flakey test with save #5616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Sep 30, 2020
| @@ -43,6 +43,7 @@ module('Integration | Component | user profile ics', function(hooks) { | |||
|
|
|||
| await render(hbs`<UserProfileIcs @isManaging={{true}} @user={{this.user}} @setIsManaging={{noop}} />`); | |||
| await click('.refresh-key'); | |||
| await settled(); | |||
There was a problem hiding this comment.
I'm guessing our test harness awaits this chain of async operations. But we must be missing something 🤔
@dropTask
*refreshKey() {
const token = yield this.randomToken(this.args.user.id);
this.args.user.set('icsFeedKey', token);
yield this.args.user.save();
this.args.setIsManaging(false);
this.hasSavedRecently = true;
yield timeout(500);
this.hasSavedRecently = false;
}
There was a problem hiding this comment.
IIRC I pulled this settled() out a week or so ago since it didn't seem to be needed anymore and tests ran, but I'm not fussed about it being back. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on master.
Seems to be flakey b/c recent commits do not suggest this was failing in the CI runs. But pulling and running locally will fail (most of the time).
emberjs/data#7337