-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output type information to BindingData
#470
Conversation
6ca2c75
to
3def63e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
7041541
to
6679f76
Compare
6679f76
to
e756d78
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
009d843
to
ed877dc
Compare
ed877dc
to
613118e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the GutHub App and FastHub seem to be showing me weird white space changes. I want to review this on my laptop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not part of this PR:
On line 669 of BindingVmHelpers, lets rename x
to result
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c48e014
to
4186415
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4186415
to
3a49795
Compare
This comment was marked as outdated.
This comment was marked as outdated.
3a49795
to
1bfdd41
Compare
58dfbab
to
86de7e3
Compare
9567dd7
to
8dfa361
Compare
8dfa361
to
bda70bb
Compare
bda70bb
to
24a541d
Compare
e9acbae
to
bbdec69
Compare
bbdec69
to
ec21987
Compare
e174e0f
to
6565689
Compare
BindingData
and VmBinding
BindingData
BindingData
BindingData
6565689
to
2505953
Compare
For each comment that had a pin put in it, can you add a comment on the new PR that is adding that code, link back to the pinned comment here, quote what I asked, and (if you responded here) quote your response? |
Done for every comment explicitly referenced as pinned for a future PR. |
This Pull Request adds another type parameter to
BindingData
which allows it to carry the actual view model property type statically through the builder.From a conversation with @TysonMN:
Note that the current usage of
Binding<'model,'msg>
constrains the new type parameter to beobj
for every construction of it (this is the entire public interface inBinding.fs
). This is intentional, as all of those bindings are by necessity constrained toobj
in order to work in the variousSubModel
andSubModelSeq
bindings. The advantage mentioned above will not be realized until after a static helper is created that can turn a binding into a statically-typed getter or setter.