Rename onewayseqlazy types #471
Conversation
53d181a to
1ef1640
Compare
1ef1640 to
5ad4c17
Compare
|
I tried to name them similar to what the equivalents are in the other types. It's a little different, but still accurate enough IMO. |
3a71d91 to
d8a4a34
Compare
|
@TysonMN this is ready for merging |
|
If you use the merge commit method, I believe the next PR #470 will be able to update from the Github UI. |
|
I don't see how this is making things more consistent. It seems less consistent to me. |
d8a4a34 to
684b852
Compare
684b852 to
8cade63
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Yes! I can rerun a build from my phone using GitHub's app. |
| @@ -410,18 +410,18 @@ module internal BindingData = | |||
| module OneWaySeqLazy = | |||
|
|
|||
| let mapMinorTypes | |||
There was a problem hiding this comment.
I think this method is clearer with the shorter names. For example, the function inMapA is passed arguments a1 and a2.
There was a problem hiding this comment.
It's to match it with the other names that are used for similar bindings. None of the other bindings use 'a and 'b. They all use 'bindingModel and 'bindingViewModel. See line 616 in this file for SubModelSeqUnkeyed and line 665 for SubModelSeqKeyed.
There was a problem hiding this comment.
Also SubModelWin uses the same names, SubModel as well but its function is in another file (I move it here in another PR).
|
Let's do PR #477 first |
|
I think it would be best to merge PR #477 first since it mostly deletes code. Do you know if there are similar trivial simplifications? (I have wanted to make that change for a long time, but I didn't realize that all my previous work made it so easy.) |
|
@TysonMN not really. I have a PR that much better sorts the BindingData from Binding, and that results in a lot of simplifications. |
|
@TysonMN also I closed this PR and removed the commits since it wasn't making sense to do it. |
Ready to merge