Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output type parameter to BindingVmHelpers #511

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Add output type parameter to BindingVmHelpers #511

merged 1 commit into from
Oct 2, 2022

Conversation

marner2
Copy link
Collaborator

@marner2 marner2 commented Sep 7, 2022 •
edited
Loading

Waiting on #516 (merged)

Adds the output type parameter to the types contained in BindingVmHelpers.fs (VmBinding and the Get/Set/Update/etc)

@marner2 marner2 force-pushed the feature/add_output_type_parameter_to_bindingvmhelpers branch 2 times, most recently from a6c9467 to 0ad3953 Compare September 7, 2022 02:56
This was referenced Sep 7, 2022
Merged
Merged
@marner2 marner2 force-pushed the feature/add_output_type_parameter_to_bindingvmhelpers branch from 0ad3953 to 59cc5af Compare September 9, 2022 01:04
@marner2 marner2 mentioned this pull request Sep 12, 2022
Closed
@TysonMN

This comment was marked as outdated.

Sign in to view
@marner2 marner2 force-pushed the feature/add_output_type_parameter_to_bindingvmhelpers branch 3 times, most recently from b282978 to 6d98b04 Compare September 16, 2022 16:04
@marner2

This comment was marked as outdated.

Sign in to view
@marner2 marner2 mentioned this pull request Sep 16, 2022
Closed
41 tasks
@TysonMN

This comment was marked as outdated.

Sign in to view
@marner2 marner2 force-pushed the feature/add_output_type_parameter_to_bindingvmhelpers branch from 6d98b04 to 05d918d Compare September 17, 2022 17:32
@marner2

This comment was marked as outdated.

Sign in to view
@marner2 marner2 marked this pull request as draft September 21, 2022 16:27
@marner2 marner2 force-pushed the feature/add_output_type_parameter_to_bindingvmhelpers branch from 05d918d to dd56879 Compare September 21, 2022 16:31
@marner2 marner2 marked this pull request as ready for review September 23, 2022 01:52
@marner2 marner2 force-pushed the feature/add_output_type_parameter_to_bindingvmhelpers branch from dd56879 to da1ee6e Compare September 23, 2022 01:54
@marner2 @TysonMN
Add 't type parameter to binding vm helpers
73fb1e2 
Also fixed tests in light of parameter
@TysonMN TysonMN force-pushed the feature/add_output_type_parameter_to_bindingvmhelpers branch from da1ee6e to 73fb1e2 Compare October 2, 2022 17:37
TysonMN
TysonMN approved these changes Oct 2, 2022
View reviewed changes
src/Elmish.WPF/DynamicViewModel.fs Show resolved Hide resolved
@TysonMN TysonMN merged commit f8a2104 into elmish:master Oct 2, 2022
@marner2 marner2 deleted the feature/add_output_type_parameter_to_bindingvmhelpers branch October 2, 2022 22:26
@TysonMN
Copy link
Member

TysonMN commented Oct 3, 2022

Instead of using ValueOption.toNull that could fail, is it possibe to add the null type constraint when the type parameter is for a view model?

@marner2
Copy link
Collaborator Author

marner2 commented Oct 3, 2022

@TysonMN the only way to do that would be to have a separate Get structure for null vs non-null types, and somehow enforce that by returning something separate on the builder side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LyndonGingerich LyndonGingerich LyndonGingerich left review comments

@TysonMN TysonMN TysonMN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marner2 @TysonMN @LyndonGingerich