[embeddable] remove getAttributeService from start API #203660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
|
/ci |
1 similar comment
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
|
/ci |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
References to deprecated APIs
History
|
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
davismcphee
approved these changes
Dec 11, 2024
ThomThomson
approved these changes
Dec 11, 2024
TinaHeiligers
approved these changes
Dec 11, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12299747533 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2024
Part of embeddable refactor cleanup AttributeService is moved from embeddable plugin to visualizations plugin. PR reduces visualizations bundle size by avoiding importing `legacy/embeddable/index.ts` in plugin page load --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 9ce5239)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
4 tasks
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2024
#204059) # Backport This will backport the following commits from `main` to `8.x`: - [[embeddable] remove getAttributeService from start API (#203660)](#203660) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2024-12-12T15:38:11Z","message":"[embeddable] remove getAttributeService from start API (#203660)\n\nPart of embeddable refactor cleanup\r\n\r\nAttributeService is moved from embeddable plugin to visualizations\r\nplugin.\r\n\r\nPR reduces visualizations bundle size by avoiding importing\r\n`legacy/embeddable/index.ts` in plugin page load\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"9ce523939279bdeba399b447849db47fa0877a23","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"title":"[embeddable] remove getAttributeService from start API","number":203660,"url":"https://github.com/elastic/kibana/pull/203660","mergeCommit":{"message":"[embeddable] remove getAttributeService from start API (#203660)\n\nPart of embeddable refactor cleanup\r\n\r\nAttributeService is moved from embeddable plugin to visualizations\r\nplugin.\r\n\r\nPR reduces visualizations bundle size by avoiding importing\r\n`legacy/embeddable/index.ts` in plugin page load\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"9ce523939279bdeba399b447849db47fa0877a23"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203660","number":203660,"mergeCommit":{"message":"[embeddable] remove getAttributeService from start API (#203660)\n\nPart of embeddable refactor cleanup\r\n\r\nAttributeService is moved from embeddable plugin to visualizations\r\nplugin.\r\n\r\nPR reduces visualizations bundle size by avoiding importing\r\n`legacy/embeddable/index.ts` in plugin page load\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"9ce523939279bdeba399b447849db47fa0877a23"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
Part of embeddable refactor cleanup AttributeService is moved from embeddable plugin to visualizations plugin. PR reduces visualizations bundle size by avoiding importing `legacy/embeddable/index.ts` in plugin page load --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of embeddable refactor cleanup
AttributeService is moved from embeddable plugin to visualizations plugin.
PR reduces visualizations bundle size by avoiding importing
legacy/embeddable/index.tsin plugin page load