Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [embeddable] remove getAttributeService from start API (#203660) #204059

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Part of embeddable refactor cleanup

AttributeService is moved from embeddable plugin to visualizations
plugin.

PR reduces visualizations bundle size by avoiding importing
`legacy/embeddable/index.ts` in plugin page load

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 9ce5239)
@kibanamachine kibanamachine merged commit 4d0170a into elastic:8.x Dec 12, 2024
13 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 138 136 -2
visualizations 492 493 +1
total -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 458 436 -22

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 320.4KB 328.9KB +8.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
embeddable 9 7 -2
visualizations 20 21 +1
total -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 68.0KB 65.8KB -2.2KB
visualizations 71.1KB 64.9KB -6.2KB
total -8.4KB
Unknown metric groups

API count

id before after diff
embeddable 564 541 -23

async chunk count

id before after diff
visualizations 15 16 +1

References to deprecated APIs

id before after diff
embeddable 13 11 -2
visualizations 58 60 +2
total -0

cc @nreese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Feature:Embedding Embedding content via iFrame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants