Skip to content

Commit

Permalink
clean up plugin size
Browse files Browse the repository at this point in the history
  • Loading branch information
nreese committed Dec 10, 2024
1 parent 6d86e6a commit 134fcbb
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ import {
import { Action } from '@kbn/ui-actions-plugin/public';
import React from 'react';
import { take } from 'rxjs';
import { apiHasVisualizeConfig, HasVisualizeConfig } from '../legacy/embeddable';
import {
apiHasVisualizeConfig,
type HasVisualizeConfig,
} from '../embeddable/interfaces/has_visualize_config';
import {
apiHasExpressionVariables,
HasExpressionVariables,
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/visualizations/public/embeddable/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
SerializedTitles,
} from '@kbn/presentation-publishing';
import { DeepPartial } from '@kbn/utility-types';
import { HasVisualizeConfig } from '../legacy/embeddable';
import type { HasVisualizeConfig } from './interfaces/has_visualize_config';
import type { Vis, VisParams, VisSavedObject } from '../types';
import type { SerializedVis } from '../vis';

Expand Down
6 changes: 4 additions & 2 deletions src/plugins/visualizations/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ export function plugin(initializerContext: PluginInitializerContext) {
/** @public static code */
export { TypesService } from './vis_types/types_service';
export { VIS_EVENT_TO_TRIGGER } from './embeddable';
export { apiHasVisualizeConfig, COMMON_VISUALIZATION_GROUPING } from './legacy/embeddable';
export { apiHasVisualizeConfig } from './embeddable/interfaces/has_visualize_config';
export { COMMON_VISUALIZATION_GROUPING } from './legacy/embeddable/constants';
export { VisualizationContainer } from './components';
export { getVisSchemas } from './vis_schemas';

Expand All @@ -41,7 +42,8 @@ export type VisualizeEmbeddableFactoryContract = PublicContract<VisualizeEmbedda
export type VisualizeEmbeddableContract = PublicContract<VisualizeEmbeddable>;
export type { SchemaConfig } from '../common/types';
export { updateOldState } from './legacy/vis_update_state';
export type { VisualizeInput, VisualizeEmbeddable, HasVisualizeConfig } from './legacy/embeddable';
export type { VisualizeInput, VisualizeEmbeddable } from './legacy/embeddable';
export type { HasVisualizeConfig } from './embeddable/interfaces/has_visualize_config';
export type { PersistedState } from './persisted_state';
export type {
ISavedVis,
Expand Down
4 changes: 0 additions & 4 deletions src/plugins/visualizations/public/legacy/embeddable/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ export { VISUALIZE_EMBEDDABLE_TYPE, COMMON_VISUALIZATION_GROUPING } from './cons
export { createVisEmbeddableFromObject } from './create_vis_embeddable_from_object';

export type { VisualizeEmbeddable, VisualizeInput } from './visualize_embeddable';
export {
type HasVisualizeConfig,
apiHasVisualizeConfig,
} from '../../embeddable/interfaces/has_visualize_config';
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { createVisAsync } from '../../vis_async';
import { convertToSerializedVis, getSavedVisualization } from '../../utils/saved_visualize_utils';
import { SerializedVis, Vis, VisSavedObject, VisualizeEmbeddableContract } from '../..';
import type { VisInstance, VisualizeServices } from '../types';
import { VisualizeInput } from '../../legacy/embeddable';
import type { VisualizeInput } from '../../legacy/embeddable';

function isErrorRelatedToRuntimeFields(error: ExpressionValueError['error']) {
const originalError = error.original || error;
Expand Down

0 comments on commit 134fcbb

Please sign in to comment.