Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] Open in Log explorer action #173272

Merged
merged 20 commits into from
Dec 18, 2023
Merged

[Dataset quality] Open in Log explorer action #173272

merged 20 commits into from
Dec 18, 2023

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Dec 13, 2023 •
edited
Loading

Closes #170236.

Changes

This PR focuses on adding an action per dataset + namespace to navigate to Observability log explorer. At the same time I took the opportunity to update Open in discover link to include the controls present in Observability Log Explorer state (atm just namespace)

  1. Extracted getRouterLinkProps to a new package for reusability.
  2. New Actions column was added to table.
  3. LogExplorerLink component was introduced, to reuse the navigation logic between the table and the flyout.
  4. getDiscoverFiltersFromState was added to combine state filters and controls into discover state when navigating to discover

Demo

Screen.Recording.2023-12-13.at.15.49.56.mov

@yngrdyn yngrdyn requested a review from a team as a code owner December 13, 2023 13:09
@yngrdyn yngrdyn self-assigned this Dec 13, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Dec 13, 2023
@yngrdyn yngrdyn requested a review from a team as a code owner December 13, 2023 14:46
@yngrdyn yngrdyn force-pushed the 170236-dataset-quality-add-actions-column branch from ddcea44 to 1bdf293 Compare December 13, 2023 17:39
tonyghiani
tonyghiani reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall, I left some suggestions for the package and the implementation but there functionally it works.

@shahzad31 shahzad31 removed the request for review from a team December 18, 2023 12:24
@yngrdyn yngrdyn requested a review from tonyghiani December 18, 2023 15:00
tonyghiani
tonyghiani approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
datasetQuality 59 68 +9
logExplorer 671 672 +1
observabilityLogExplorer 173 174 +1
total +11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/router-utils - 1 +1
logExplorer 84 87 +3
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityLogExplorer 138.0KB 138.0KB +59.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 34.4KB 35.3KB +919.0B
logExplorer 38.7KB 39.4KB +734.0B
total +1.6KB
Unknown metric groups

API count

id before after diff
@kbn/router-utils - 2 +2
logExplorer 84 87 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

@yngrdyn yngrdyn merged commit ce293db into elastic:main Dec 18, 2023
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 18, 2023
@yngrdyn yngrdyn mentioned this pull request Dec 19, 2023
Merged
yngrdyn added a commit that referenced this pull request Dec 19, 2023
@yngrdyn
[Dataset quality] Sort by datasetname + Find degradedDocs using raw d…
d959e85 
…ataset name (#173603)

This PR focuses on solving a couple of issues:

1. In #173087 the dataset human
title was brought to the table. Even though, we still need to sort the
column by the `raw` name of the dataset.

#### Before


https://github.com/elastic/kibana/assets/1313018/e389ea24-55fc-4854-af32-67e3693fe4bb

#### After


https://github.com/elastic/kibana/assets/1313018/cbb529e5-12cf-4432-be02-828c61143f17


2. In #173272 `rawName` property
was added to `DataStreamStat` class so we could keep the logic of
splitting the raw dataset name in just one place. We need to find the
`degradedDocs` number from the raw dataset instead of the name we are
keeping in the class.

#### Before


https://github.com/elastic/kibana/assets/1313018/e8d41966-24cd-45e8-8ab2-3de3b043e730

#### After


https://github.com/elastic/kibana/assets/1313018/e9af6c9d-5081-41e5-bfb0-c88264e4b349
@yngrdyn yngrdyn added the Team:obs-ux-logs Observability Logs User Experience Team label Mar 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees

@yngrdyn yngrdyn

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dataset quality] Add actions column
6 participants
@yngrdyn @apmmachine @kibana-ci @elasticmachine @tonyghiani @kibanamachine