Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] Dedicated column for namespace #173087

Merged
merged 20 commits into from
Dec 18, 2023
Merged

[Dataset quality] Dedicated column for namespace #173087

merged 20 commits into from
Dec 18, 2023

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Dec 11, 2023 •
edited
Loading

Changes

  1. Splits datasetname + namespace from Dataset name column.
  2. Creates a dedicated column for namespace.
  3. Bring the human readable name from datasets.

Before

image

After

image

@yngrdyn yngrdyn self-assigned this Dec 11, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn marked this pull request as ready for review December 12, 2023 09:18
@yngrdyn yngrdyn requested a review from a team as a code owner December 12, 2023 09:18
@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Dec 12, 2023
@yngrdyn
Copy link
Contributor Author

yngrdyn commented Dec 12, 2023

/oblt-deploy

@yngrdyn yngrdyn mentioned this pull request Dec 12, 2023
Closed
@yngrdyn
Copy link
Contributor Author

yngrdyn commented Dec 12, 2023

/oblt-deploy

3 similar comments
@yngrdyn
Copy link
Contributor Author

yngrdyn commented Dec 12, 2023

/oblt-deploy

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Dec 13, 2023

/oblt-deploy

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Dec 13, 2023

/oblt-deploy

@yngrdyn yngrdyn mentioned this pull request Dec 14, 2023
Merged
tonyghiani
tonyghiani approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a feature perspective the implementation LGTM, looking at the type definitions I feel we start to repeat across different plugins informations which can be unified into a plugin, such as the DatasetType definitions or other info.

We can think about some refactor of this in conjunction with the Fleet team, but this is out of the scope of this issue 👌

@yngrdyn yngrdyn enabled auto-merge (squash) December 18, 2023 10:15
@yngrdyn yngrdyn disabled auto-merge December 18, 2023 12:15
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
datasetQuality 4 2 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 34.0KB 34.4KB +414.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

@yngrdyn yngrdyn merged commit 9a65337 into elastic:main Dec 18, 2023
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 18, 2023
@yngrdyn yngrdyn mentioned this pull request Dec 19, 2023
Merged
yngrdyn added a commit that referenced this pull request Dec 19, 2023
@yngrdyn
[Dataset quality] Sort by datasetname + Find degradedDocs using raw d…
d959e85 
…ataset name (#173603)

This PR focuses on solving a couple of issues:

1. In #173087 the dataset human
title was brought to the table. Even though, we still need to sort the
column by the `raw` name of the dataset.

#### Before


https://github.com/elastic/kibana/assets/1313018/e389ea24-55fc-4854-af32-67e3693fe4bb

#### After


https://github.com/elastic/kibana/assets/1313018/cbb529e5-12cf-4432-be02-828c61143f17


2. In #173272 `rawName` property
was added to `DataStreamStat` class so we could keep the logic of
splitting the raw dataset name in just one place. We need to find the
`degradedDocs` number from the raw dataset instead of the name we are
keeping in the class.

#### Before


https://github.com/elastic/kibana/assets/1313018/e8d41966-24cd-45e8-8ab2-3de3b043e730

#### After


https://github.com/elastic/kibana/assets/1313018/e9af6c9d-5081-41e5-bfb0-c88264e4b349
@yngrdyn yngrdyn added the Team:obs-ux-logs Observability Logs User Experience Team label Mar 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees

@yngrdyn yngrdyn

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yngrdyn @apmmachine @kibana-ci @elasticmachine @tonyghiani @kibanamachine