Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] Add dataset filters #170242

Closed
1 task done
yngrdyn opened this issue Oct 31, 2023 · 4 comments · Fixed by #174906, #176162 or #176611
Closed
1 task done

[Dataset quality] Add dataset filters #170242

yngrdyn opened this issue Oct 31, 2023 · 4 comments · Fixed by #174906, #176162 or #176611
Assignees
@yngrdyn
Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team

Comments

@yngrdyn
Copy link
Contributor

yngrdyn commented Oct 31, 2023 •
edited
Loading

📓 Summary

Allow users to filter dataset health view so they can explore the page as they feel is most useful for them.

image

✔️ Acceptance criteria

Above the table there is

  • an EUI search bar control with
    a search field, that searches the dataset name by default
  • a toggle "Show inactive datasets" that is disabled by default and, when enabled, filters for datasets that have backing indices with a maximum timestamp within the last 24 hours.
  • a Health dropdown that will show Integrations that filters the table to show the selected integrations. We can start by making this dropdown a single select but consider to include it as a multiselect dropdown.
  • A datetime selector that will allow users to change the timeframe, affecting only the table.
  • Rows where Last activity is higher than last 24h should display a tooltip with Try expanding the time range above for more results

Tasks
Preview Give feedback
@yngrdyn yngrdyn added Team:obs-ux-logs Observability Logs User Experience Team Feature:Dataset Health labels Oct 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@mohamedhamed-ahmed
Copy link
Contributor

Rows where Last activity is higher than last 24h should display a tooltip with Try expanding the time range above for more results

Does this mean we will still show datasets that don't match the 24h filter?

Do we maybe need to add a quick filter buttons need the dataset name and integration, to quickly filter for those instead of them being types in the search bar?

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Nov 8, 2023

Does this mean we will still show datasets that don't match the 24h filter?

We will show them whenever Show inactive datasets is on.

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Nov 8, 2023

Do we maybe need to add a quick filter buttons need the dataset name and integration, to quickly filter for those instead of them being types in the search bar?

didn't complete get this. We have sor t of a quick filter for integrations already

@yngrdyn yngrdyn changed the title [Dataset health] Add dataset filters [Dataset quality] Add dataset filters Nov 9, 2023
@yngrdyn yngrdyn self-assigned this Dec 5, 2023
@yngrdyn yngrdyn linked a pull request Feb 2, 2024 that will close this issue
[Dataset quality] State management #174906
Merged
@yngrdyn yngrdyn mentioned this issue Feb 2, 2024
Merged
@yngrdyn yngrdyn linked a pull request Feb 2, 2024 that will close this issue
[Dataset quality] Toggle for showing/hidding inactive datasets and full dataset names #176162
Merged
yngrdyn added a commit that referenced this issue Feb 5, 2024
@yngrdyn
[Dataset quality] Toggle for showing/hidding inactive datasets and fu…
0ec28c9 
…ll dataset names (#176162)

Relates to #170242.

### Changes
- Dedicated component for switch with description was created
(`DescriptiveSwitch`).
- Two new events where added to the machine: 
- `TOGGLE_INACTIVE_DATASETS`: Used to toggle `Show inactive datasets`
switch.
- `TOGGLE_FULL_DATASET_NAMES`: Used to toggle `Show full dataset names`
switch.
- Some minor changes around typings, to reuse the existing ones instead
of duplicating states in around controller public state.
- DatasetQualityUrlSchema was also updated so the consumer could hold
the properties around the switches.
- Fixed a small issue when merging degradedDocStats into
dataStreamStats, I was using `DataStreamStat.name` where I should be
using `DataStreamStat.rawName` from matching datastreams.

#### App statechart
<img width="1099" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/7f0308c6-f8f5-4050-9498-e566370372f2">


#### Demo


https://github.com/elastic/kibana/assets/1313018/971efb30-2562-4409-8973-25b4972e6793

#### Note for reviewers
- Timefilter selector will be included in a follow up PR.
- `timeRange` was added to the state to have the same `from`/`to`, that
was used for querying data, when filtering inactive datasets.
@yngrdyn yngrdyn reopened this Feb 6, 2024
fkanout pushed a commit to fkanout/kibana that referenced this issue Feb 7, 2024
@yngrdyn @fkanout
[Dataset quality] Toggle for showing/hidding inactive datasets and fu…
71e0e0e 
…ll dataset names (elastic#176162)

Relates to elastic#170242.

### Changes
- Dedicated component for switch with description was created
(`DescriptiveSwitch`).
- Two new events where added to the machine: 
- `TOGGLE_INACTIVE_DATASETS`: Used to toggle `Show inactive datasets`
switch.
- `TOGGLE_FULL_DATASET_NAMES`: Used to toggle `Show full dataset names`
switch.
- Some minor changes around typings, to reuse the existing ones instead
of duplicating states in around controller public state.
- DatasetQualityUrlSchema was also updated so the consumer could hold
the properties around the switches.
- Fixed a small issue when merging degradedDocStats into
dataStreamStats, I was using `DataStreamStat.name` where I should be
using `DataStreamStat.rawName` from matching datastreams.

#### App statechart
<img width="1099" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/7f0308c6-f8f5-4050-9498-e566370372f2">


#### Demo


https://github.com/elastic/kibana/assets/1313018/971efb30-2562-4409-8973-25b4972e6793

#### Note for reviewers
- Timefilter selector will be included in a follow up PR.
- `timeRange` was added to the state to have the same `from`/`to`, that
was used for querying data, when filtering inactive datasets.
@yngrdyn yngrdyn mentioned this issue Feb 14, 2024
Merged
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@yngrdyn @CoenWarmer
[Dataset quality] Toggle for showing/hidding inactive datasets and fu…
1180890 
…ll dataset names (elastic#176162)

Relates to elastic#170242.

### Changes
- Dedicated component for switch with description was created
(`DescriptiveSwitch`).
- Two new events where added to the machine: 
- `TOGGLE_INACTIVE_DATASETS`: Used to toggle `Show inactive datasets`
switch.
- `TOGGLE_FULL_DATASET_NAMES`: Used to toggle `Show full dataset names`
switch.
- Some minor changes around typings, to reuse the existing ones instead
of duplicating states in around controller public state.
- DatasetQualityUrlSchema was also updated so the consumer could hold
the properties around the switches.
- Fixed a small issue when merging degradedDocStats into
dataStreamStats, I was using `DataStreamStat.name` where I should be
using `DataStreamStat.rawName` from matching datastreams.

#### App statechart
<img width="1099" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/7f0308c6-f8f5-4050-9498-e566370372f2">


#### Demo


https://github.com/elastic/kibana/assets/1313018/971efb30-2562-4409-8973-25b4972e6793

#### Note for reviewers
- Timefilter selector will be included in a follow up PR.
- `timeRange` was added to the state to have the same `from`/`to`, that
was used for querying data, when filtering inactive datasets.
@yngrdyn yngrdyn linked a pull request Feb 20, 2024 that will close this issue
[Dataset quality] Filters for timeRange, integrations and datasetQuery #176611
Merged
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@yngrdyn @fkanout
[Dataset quality] Toggle for showing/hidding inactive datasets and fu…
48c74ff 
…ll dataset names (elastic#176162)

Relates to elastic#170242.

### Changes
- Dedicated component for switch with description was created
(`DescriptiveSwitch`).
- Two new events where added to the machine: 
- `TOGGLE_INACTIVE_DATASETS`: Used to toggle `Show inactive datasets`
switch.
- `TOGGLE_FULL_DATASET_NAMES`: Used to toggle `Show full dataset names`
switch.
- Some minor changes around typings, to reuse the existing ones instead
of duplicating states in around controller public state.
- DatasetQualityUrlSchema was also updated so the consumer could hold
the properties around the switches.
- Fixed a small issue when merging degradedDocStats into
dataStreamStats, I was using `DataStreamStat.name` where I should be
using `DataStreamStat.rawName` from matching datastreams.

#### App statechart
<img width="1099" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/7f0308c6-f8f5-4050-9498-e566370372f2">


#### Demo


https://github.com/elastic/kibana/assets/1313018/971efb30-2562-4409-8973-25b4972e6793

#### Note for reviewers
- Timefilter selector will be included in a follow up PR.
- `timeRange` was added to the state to have the same `from`/`to`, that
was used for querying data, when filtering inactive datasets.
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@yngrdyn @kibanamachine @fkanout
[Dataset quality] Filters for timeRange, integrations and datasetQuery (
7b546a3 
elastic#176611)

Closes elastic#170242

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yngrdyn yngrdyn

Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
3 participants
@yngrdyn @mohamedhamed-ahmed @elasticmachine