Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] Toggle for showing/hidding inactive datasets and full dataset names #176162

Merged
merged 7 commits into from
Feb 5, 2024
Merged

[Dataset quality] Toggle for showing/hidding inactive datasets and full dataset names #176162

merged 7 commits into from
Feb 5, 2024

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Feb 2, 2024 •
edited
Loading

Relates to #170242.

Changes

  • Dedicated component for switch with description was created (DescriptiveSwitch).
  • Two new events where added to the machine:
    • TOGGLE_INACTIVE_DATASETS: Used to toggle Show inactive datasets switch.
    • TOGGLE_FULL_DATASET_NAMES: Used to toggle Show full dataset names switch.
    • Some minor changes around typings, to reuse the existing ones instead of duplicating states in around controller public state.
    • DatasetQualityUrlSchema was also updated so the consumer could hold the properties around the switches.
    • Fixed a small issue when merging degradedDocStats into dataStreamStats, I was using DataStreamStat.name where I should be using DataStreamStat.rawName from matching datastreams.

App statechart

image

Demo

Screen.Recording.2024-02-02.at.16.25.57.mov

Note for reviewers

  • Timefilter selector will be included in a follow up PR.
  • timeRange was added to the state to have the same from/to, that was used for querying data, when filtering inactive datasets.

@yngrdyn yngrdyn requested a review from a team as a code owner February 2, 2024 15:32
@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Feb 2, 2024
@yngrdyn yngrdyn self-assigned this Feb 2, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn linked an issue Feb 2, 2024 that may be closed by this pull request
[Dataset quality] Add dataset filters #170242
Closed
@mohamedhamed-ahmed mohamedhamed-ahmed self-requested a review February 5, 2024 13:55
@mohamedhamed-ahmed
Copy link
Contributor

LGTM!! Great work
Just a couple of small points

  1. Do we want to call it name or names
  2. the tooltip icon looks a bit off to me, might want to be centered with the text?
Screenshot 2024-02-05 at 17 35 20

@mohamedhamed-ahmed
Copy link
Contributor

mohamedhamed-ahmed commented Feb 5, 2024 •
edited
Loading

Also noticed the numbers on the table are now wrongly computed, we are displaying the page size always.
Screenshot 2024-02-05 at 17 41 02

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Feb 5, 2024

Do we want to call it name or names

@mdbirnstiehl will the best one to help us with that question 🙏🏼

@yngrdyn yngrdyn enabled auto-merge (squash) February 5, 2024 16:12
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #69 / InfraOps App Metrics UI Home page Saved Views "before all" hook for "should render a button with the view name"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
datasetQuality 136 138 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 126.2KB 129.0KB +2.8KB
observabilityLogsExplorer 144.4KB 144.5KB +36.0B
total +2.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 7.0KB 7.7KB +680.0B
observabilityLogsExplorer 12.3KB 12.4KB +115.0B
total +795.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

@yngrdyn yngrdyn merged commit 0ec28c9 into elastic:main Feb 5, 2024
18 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Feb 5, 2024
fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 7, 2024
@yngrdyn @fkanout
[Dataset quality] Toggle for showing/hidding inactive datasets and fu…
71e0e0e 
…ll dataset names (elastic#176162)

Relates to elastic#170242.

### Changes
- Dedicated component for switch with description was created
(`DescriptiveSwitch`).
- Two new events where added to the machine: 
- `TOGGLE_INACTIVE_DATASETS`: Used to toggle `Show inactive datasets`
switch.
- `TOGGLE_FULL_DATASET_NAMES`: Used to toggle `Show full dataset names`
switch.
- Some minor changes around typings, to reuse the existing ones instead
of duplicating states in around controller public state.
- DatasetQualityUrlSchema was also updated so the consumer could hold
the properties around the switches.
- Fixed a small issue when merging degradedDocStats into
dataStreamStats, I was using `DataStreamStat.name` where I should be
using `DataStreamStat.rawName` from matching datastreams.

#### App statechart
<img width="1099" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/7f0308c6-f8f5-4050-9498-e566370372f2">


#### Demo


https://github.com/elastic/kibana/assets/1313018/971efb30-2562-4409-8973-25b4972e6793

#### Note for reviewers
- Timefilter selector will be included in a follow up PR.
- `timeRange` was added to the state to have the same `from`/`to`, that
was used for querying data, when filtering inactive datasets.
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@yngrdyn @CoenWarmer
[Dataset quality] Toggle for showing/hidding inactive datasets and fu…
1180890 
…ll dataset names (elastic#176162)

Relates to elastic#170242.

### Changes
- Dedicated component for switch with description was created
(`DescriptiveSwitch`).
- Two new events where added to the machine: 
- `TOGGLE_INACTIVE_DATASETS`: Used to toggle `Show inactive datasets`
switch.
- `TOGGLE_FULL_DATASET_NAMES`: Used to toggle `Show full dataset names`
switch.
- Some minor changes around typings, to reuse the existing ones instead
of duplicating states in around controller public state.
- DatasetQualityUrlSchema was also updated so the consumer could hold
the properties around the switches.
- Fixed a small issue when merging degradedDocStats into
dataStreamStats, I was using `DataStreamStat.name` where I should be
using `DataStreamStat.rawName` from matching datastreams.

#### App statechart
<img width="1099" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/7f0308c6-f8f5-4050-9498-e566370372f2">


#### Demo


https://github.com/elastic/kibana/assets/1313018/971efb30-2562-4409-8973-25b4972e6793

#### Note for reviewers
- Timefilter selector will be included in a follow up PR.
- `timeRange` was added to the state to have the same `from`/`to`, that
was used for querying data, when filtering inactive datasets.
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@yngrdyn @fkanout
[Dataset quality] Toggle for showing/hidding inactive datasets and fu…
48c74ff 
…ll dataset names (elastic#176162)

Relates to elastic#170242.

### Changes
- Dedicated component for switch with description was created
(`DescriptiveSwitch`).
- Two new events where added to the machine: 
- `TOGGLE_INACTIVE_DATASETS`: Used to toggle `Show inactive datasets`
switch.
- `TOGGLE_FULL_DATASET_NAMES`: Used to toggle `Show full dataset names`
switch.
- Some minor changes around typings, to reuse the existing ones instead
of duplicating states in around controller public state.
- DatasetQualityUrlSchema was also updated so the consumer could hold
the properties around the switches.
- Fixed a small issue when merging degradedDocStats into
dataStreamStats, I was using `DataStreamStat.name` where I should be
using `DataStreamStat.rawName` from matching datastreams.

#### App statechart
<img width="1099" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/7f0308c6-f8f5-4050-9498-e566370372f2">


#### Demo


https://github.com/elastic/kibana/assets/1313018/971efb30-2562-4409-8973-25b4972e6793

#### Note for reviewers
- Timefilter selector will be included in a follow up PR.
- `timeRange` was added to the state to have the same `from`/`to`, that
was used for querying data, when filtering inactive datasets.
@yngrdyn yngrdyn added the Team:obs-ux-logs Observability Logs User Experience Team label Mar 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedhamed-ahmed mohamedhamed-ahmed mohamedhamed-ahmed approved these changes

Assignees

@yngrdyn yngrdyn

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dataset quality] Add dataset filters
6 participants
@yngrdyn @apmmachine @mohamedhamed-ahmed @kibana-ci @elasticmachine @kibanamachine