-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset quality] Filters for timeRange, integrations and datasetQuery #176611
Conversation
…e using selectedIntegrations
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
… into 170242-timeframe-selector
b9c0301
to
000986c
Compare
6c3ab47
to
8fd4bdb
Compare
I played around with the PR and got some questions:
|
The page contents shift a bit when the table content changes, can we keep this fixed as it feels a bit annoying TableColumnsResizing.mov |
We are quite limited regarding the search bar, mainly because of the DataStreams API, there we are only able to filter using a pattern
This was already discussed in the figma file.
This is good point! I'll take a look on this one |
As we discussed offline, I will switch to UI filtering instead of going to our endpoint and filter using the dataStreams API, filtering in the UI will give more flexibility than just having a pattern. Users for example would be able to filter two datasets that comes from different integrations with a multi select (as they can do for example for integrations) |
x-pack/plugins/dataset_quality/public/utils/filter_inactive_datasets.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/dataset_quality/public/utils/filter_inactive_datasets.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/dataset_quality/public/state_machines/dataset_quality_controller/src/types.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/dataset_quality/public/components/dataset_quality/filters/filter_bar.tsx
Show resolved
Hide resolved
.../plugins/dataset_quality/public/components/dataset_quality/filters/integrations_selector.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Great work 🚀
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @yngrdyn |
elastic#176611) Closes elastic#170242 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Relates to #170242
📝 Summary
This PR introduces a set of filters for the table inside the dataset quality page. With these changes users now will be able to filter by timeRange, integrations and dataset name.
As part of this work, we had implemented the URL schema in the consumer observability log explorer, so anyone could share the current state of the page with others.
💡For Reviewers
State Machine
The changes is the state machine includes new events to handle the update of the selected integrations, selected query, selected timeRange and refreshing the data when changing the timeRange (or using the autorefresh in the timerange component).
@kbn/timerange
This package was added to handle timerange utilities, in particular it exposes two functions
getDateRange
andgetISODateRange
that helps converting from timeranges like{ from: 'now-24h', to: 'now'}
into their respective timestamps or ISO string dates.✅ Testing
🎥 Demos
Screen.Recording.2024-02-19.at.16.01.39.mov
Screen.Recording.2024-02-19.at.16.36.45.mov
Screen.Recording.2024-02-19.at.16.39.37.mov