CR changes: simplifying code

elastic · Dec 14, 2023 · 777c0fd · 777c0fd
1 parent 6164774
commit 777c0fd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/x-pack/plugins/dataset_quality/public/components/log_explorer_link.tsx b/x-pack/plugins/dataset_quality/public/components/log_explorer_link.tsx
@@ -23,7 +23,7 @@ export const LogExplorerLink = React.memo(
     const [dataset, namespace] = dataStreamStat.title.split('-');
     const integration = dataStreamStat.integration?.name;
 
-    const params = {
+    const params: SingleDatasetLocatorParams = {
       dataset,
       timeRange: {
         from: 'now-1d',
@@ -36,16 +36,15 @@ export const LogExplorerLink = React.memo(
           values: [namespace],
         },
       },
-    } as SingleDatasetLocatorParams;
+    };
+
+    const singleDatasetLocator =
+      share.url.locators.get<SingleDatasetLocatorParams>(SINGLE_DATASET_LOCATOR_ID);
 
-    const urlToLogExplorer = share.url.locators
-      .get<SingleDatasetLocatorParams>(SINGLE_DATASET_LOCATOR_ID)
-      ?.getRedirectUrl(params);
+    const urlToLogExplorer = singleDatasetLocator?.getRedirectUrl(params);
 
     const navigateToLogExplorer = () => {
-      share.url.locators
-        .get<SingleDatasetLocatorParams>(SINGLE_DATASET_LOCATOR_ID)
-        ?.navigate(params) as Promise<void>;
+      singleDatasetLocator?.navigate(params) as Promise<void>;
     };
 
     const logExplorerLinkProps = getRouterLinkProps({

diff --git a/x-pack/plugins/log_explorer/public/utils/convert_discover_app_state.ts b/x-pack/plugins/log_explorer/public/utils/convert_discover_app_state.ts
@@ -87,6 +87,7 @@ const createDiscoverPhrasesFilter = ({
   ({
     meta: {
       key,
+      negate,
       type: FILTERS.PHRASES,
       params: values,
     },
@@ -116,17 +117,16 @@ const createDiscoverExistsFilter = ({
 export const getDiscoverFiltersFromState = (filters: Filter[] = [], controls?: ControlOptions) => [
   ...filters,
   ...(controls
-    ? Object.keys(controls).map((key) =>
+    ? (Object.keys(controls) as Array<keyof ControlOptions>).map((key) =>
         controls[key as keyof ControlOptions]?.selection.type === 'exists'
           ? createDiscoverExistsFilter({
               key,
-              negate: controls[key as keyof ControlOptions]?.mode === 'exclude',
+              negate: controls[key]?.mode === 'exclude',
             })
           : createDiscoverPhrasesFilter({
               key,
-              values: (controls[key as keyof ControlOptions]?.selection as OptionsListControlOption)
-                .selectedOptions,
-              negate: controls[key as keyof ControlOptions]?.mode === 'exclude',
+              values: (controls[key]?.selection as OptionsListControlOption).selectedOptions,
+              negate: controls[key]?.mode === 'exclude',
             })
       )
     : []),