Remove details from migrations logging #172732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
approved these changes
Dec 6, 2023
|
@elastic/kibana-core I am sorry for the crude PR. Please feel free to implement a more nuanced fix in a follow-up. In the interest of release timing, I opted for speed over finesse |
Both of these fail because the snapshots are stale. The "Jest Integration Tests #2 / migration v2 clean ups if migration fails" failure I'll need to investigate |
Thanks, @TinaHeiligers. I think the integration test was relying on the log data I removed to verify the cleanup worked correctly. I've disabled that portion of the test in f1f9c5c |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 6, 2023
## Summary Bluntly removes details from a debug log message. (cherry picked from commit f5d1e45)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 6, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [Remove details from migrations logging (#172732)](#172732) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Larry Gregory","email":"larry.gregory@elastic.co"},"sourceCommit":{"committedDate":"2023-12-06T22:37:49Z","message":"Remove details from migrations logging (#172732)\n\n## Summary\r\n\r\nBluntly removes details from a debug log message.","sha":"f5d1e45e5923d68eec2fe87319b07fceb3767ad9","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","backport:all-open","v8.12.0"],"number":172732,"url":"https://github.com/elastic/kibana/pull/172732","mergeCommit":{"message":"Remove details from migrations logging (#172732)\n\n## Summary\r\n\r\nBluntly removes details from a debug log message.","sha":"f5d1e45e5923d68eec2fe87319b07fceb3767ad9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172732","number":172732,"mergeCommit":{"message":"Remove details from migrations logging (#172732)\n\n## Summary\r\n\r\nBluntly removes details from a debug log message.","sha":"f5d1e45e5923d68eec2fe87319b07fceb3767ad9"}}]}] BACKPORT--> Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
TinaHeiligers
added a commit
that referenced
this pull request
Dec 7, 2023
Manual backport of #172732
|
This PR didn't make it on time for the latest 8.11.2 BC. Updating the labels. |
TinaHeiligers
added a commit
that referenced
this pull request
Dec 8, 2023
code cleanup from #172732 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 8, 2023
code cleanup from elastic#172732 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 22df919)
kibanamachine
referenced
this pull request
Dec 8, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [[Tech debt] Removes commented out code (#172858)](#172858) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2023-12-08T07:31:17Z","message":"[Tech debt] Removes commented out code (#172858)\n\ncode cleanup from https://github.com/elastic/kibana/pull/172732\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"22df91900bcd436d32d029e58bca829c767143bb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","Feature:Migrations","backport:all-open","v8.13.0"],"number":172858,"url":"https://github.com/elastic/kibana/pull/172858","mergeCommit":{"message":"[Tech debt] Removes commented out code (#172858)\n\ncode cleanup from https://github.com/elastic/kibana/pull/172732\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"22df91900bcd436d32d029e58bca829c767143bb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172858","number":172858,"mergeCommit":{"message":"[Tech debt] Removes commented out code (#172858)\n\ncode cleanup from https://github.com/elastic/kibana/pull/172732\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"22df91900bcd436d32d029e58bca829c767143bb"}}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bluntly removes details from a debug log message.