-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech debt] Removes commented out code #172858
Merged
TinaHeiligers
merged 2 commits into
elastic:main
from
TinaHeiligers:core-migrations_state_machine_test_cleanup
Dec 8, 2023
Merged
[Tech debt] Removes commented out code #172858
TinaHeiligers
merged 2 commits into
elastic:main
from
TinaHeiligers:core-migrations_state_machine_test_cleanup
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
chore
Feature:Migrations
backport:all-open
Backport to all branches that could still receive a release
labels
Dec 7, 2023
TinaHeiligers
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Dec 7, 2023
/ci |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Dec 8, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 8, 2023
code cleanup from elastic#172732 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 22df919)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 8, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [[Tech debt] Removes commented out code (#172858)](#172858) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2023-12-08T07:31:17Z","message":"[Tech debt] Removes commented out code (#172858)\n\ncode cleanup from https://github.com/elastic/kibana/pull/172732\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"22df91900bcd436d32d029e58bca829c767143bb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","Feature:Migrations","backport:all-open","v8.13.0"],"number":172858,"url":"https://github.com/elastic/kibana/pull/172858","mergeCommit":{"message":"[Tech debt] Removes commented out code (#172858)\n\ncode cleanup from https://github.com/elastic/kibana/pull/172732\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"22df91900bcd436d32d029e58bca829c767143bb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172858","number":172858,"mergeCommit":{"message":"[Tech debt] Removes commented out code (#172858)\n\ncode cleanup from https://github.com/elastic/kibana/pull/172732\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"22df91900bcd436d32d029e58bca829c767143bb"}}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:all-open
Backport to all branches that could still receive a release
chore
Feature:Migrations
release_note:skip
Skip the PR/issue when compiling release notes
v8.12.0
v8.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code cleanup from #172732