Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech debt] Removes commented out code #172858

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Dec 7, 2023

code cleanup from #172732

@TinaHeiligers TinaHeiligers added chore Feature:Migrations backport:all-open Backport to all branches that could still receive a release labels Dec 7, 2023
@TinaHeiligers TinaHeiligers self-assigned this Dec 7, 2023
@TinaHeiligers TinaHeiligers added the release_note:skip Skip the PR/issue when compiling release notes label Dec 7, 2023
@TinaHeiligers TinaHeiligers marked this pull request as ready for review December 7, 2023 17:44
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner December 7, 2023 17:44
@TinaHeiligers
Copy link
Contributor Author

/ci

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @TinaHeiligers

@TinaHeiligers TinaHeiligers enabled auto-merge (squash) December 7, 2023 21:35
@TinaHeiligers TinaHeiligers merged commit 22df919 into elastic:main Dec 8, 2023
35 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 8, 2023
code cleanup from elastic#172732

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 22df919)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 172858

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 8, 2023
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Tech debt] Removes commented out code
(#172858)](#172858)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christiane (Tina)
Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2023-12-08T07:31:17Z","message":"[Tech
debt] Removes commented out code (#172858)\n\ncode cleanup from
https://github.com/elastic/kibana/pull/172732\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"22df91900bcd436d32d029e58bca829c767143bb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","Feature:Migrations","backport:all-open","v8.13.0"],"number":172858,"url":"https://github.com/elastic/kibana/pull/172858","mergeCommit":{"message":"[Tech
debt] Removes commented out code (#172858)\n\ncode cleanup from
https://github.com/elastic/kibana/pull/172732\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"22df91900bcd436d32d029e58bca829c767143bb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172858","number":172858,"mergeCommit":{"message":"[Tech
debt] Removes commented out code (#172858)\n\ncode cleanup from
https://github.com/elastic/kibana/pull/172732\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"22df91900bcd436d32d029e58bca829c767143bb"}}]}]
BACKPORT-->

Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release chore Feature:Migrations release_note:skip Skip the PR/issue when compiling release notes v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants