Skip to content

Commit

Permalink
[8.11] Remove details from migrations logging (#172732) (#172743)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.11`:
- [Remove details from migrations logging
(#172732)](#172732)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Larry
Gregory","email":"larry.gregory@elastic.co"},"sourceCommit":{"committedDate":"2023-12-06T22:37:49Z","message":"Remove
details from migrations logging (#172732)\n\n## Summary\r\n\r\nBluntly
removes details from a debug log
message.","sha":"f5d1e45e5923d68eec2fe87319b07fceb3767ad9","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","backport:all-open","v8.12.0"],"number":172732,"url":"https://github.com/elastic/kibana/pull/172732","mergeCommit":{"message":"Remove
details from migrations logging (#172732)\n\n## Summary\r\n\r\nBluntly
removes details from a debug log
message.","sha":"f5d1e45e5923d68eec2fe87319b07fceb3767ad9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172732","number":172732,"mergeCommit":{"message":"Remove
details from migrations logging (#172732)\n\n## Summary\r\n\r\nBluntly
removes details from a debug log
message.","sha":"f5d1e45e5923d68eec2fe87319b07fceb3767ad9"}}]}]
BACKPORT-->

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
  • Loading branch information
kibanamachine and legrego authored Dec 6, 2023
1 parent 385f33e commit 28cd9eb
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 27 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@ export const logActionResponse = (
state: LogAwareState,
res: unknown
) => {
logger.debug(logMessagePrefix + `${state.controlState} RESPONSE`, res as LogMeta);
logger.debug(logMessagePrefix + `${state.controlState} RESPONSE`);
};
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('migration v2', () => {
});

it('clean ups if migration fails', async () => {
const { runMigrations, client } = await setupNextMinor();
const { runMigrations /* , client */ } = await setupNextMinor();

await expect(runMigrations()).rejects.toThrowErrorMatchingInlineSnapshot(`
"Unable to complete saved object migrations for the [${defaultKibanaIndex}] index: Migrations failed. Reason: 1 corrupt saved object documents were found: corrupt:2baf4de0-a6d4-11ed-ba5a-39196fc76e60
Expand All @@ -63,7 +63,7 @@ describe('migration v2', () => {
);

expect(logRecordWithPit).toBeTruthy();

/* TEMPORARILY DISABLE
const pitId = logRecordWithPit.right.pitId;
expect(pitId).toBeTruthy();
Expand All @@ -75,6 +75,7 @@ describe('migration v2', () => {
})
// throws an exception that cannot search with closed PIT
).rejects.toThrow(/search_phase_execution_exception/);
*/
});

afterEach(async () => {
Expand Down

0 comments on commit 28cd9eb

Please sign in to comment.