Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API Events to Endpoint Security Advanced Policy #156718

Merged
merged 1 commit into from
May 4, 2023
Merged

Add API Events to Endpoint Security Advanced Policy #156718

merged 1 commit into from
May 4, 2023

Conversation

gabriellandau
Copy link
Contributor

@gabriellandau gabriellandau commented May 4, 2023 •
edited by kibanamachine
Loading

Summary

Adds a another advanced option for Endpoint to Policy.

image

Checklist

Delete any items that are not applicable to this PR.

@gabriellandau gabriellandau added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.8.0 v8.9.0 labels May 4, 2023
@gabriellandau gabriellandau requested a review from a team as a code owner May 4, 2023 17:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

kevinlog
kevinlog approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for putting this up!

@gabriellandau gabriellandau enabled auto-merge (squash) May 4, 2023 17:58
@gabriellandau gabriellandau merged commit a69cb10 into elastic:main May 4, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +592.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request May 4, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 4, 2023
@gabriellandau
Add API Events to Endpoint Security Advanced Policy (elastic#156718)
add9c37 
## Summary

Adds a another advanced option for Endpoint to Policy.

![image](https://user-images.githubusercontent.com/42078554/236277606-3dd97609-733e-44b3-8230-60f9ef728adc.png)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

<!--ONMERGE {"backportTargets":["8.8"]} ONMERGE-->

(cherry picked from commit a69cb10)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@gabriellandau gabriellandau deleted the add-endpoint-security-advanced-policy-api-event-kill-switch branch May 4, 2023 19:16
kibanamachine added a commit that referenced this pull request May 4, 2023
@kibanamachine @gabriellandau
[8.8] Add API Events to Endpoint Security Advanced Policy (#156718) (#…
b27bcb8 
…156726)

# Backport

This will backport the following commits from `main` to `8.8`:
- [Add API Events to Endpoint Security Advanced Policy
(#156718)](#156718)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gabriel
Landau","email":"42078554+gabriellandau@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-04T18:51:38Z","message":"Add
API Events to Endpoint Security Advanced Policy (#156718)\n\n##
Summary\r\n\r\nAdds a another advanced option for Endpoint to
Policy.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/42078554/236277606-3dd97609-733e-44b3-8230-60f9ef728adc.png)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n\r\n<!--ONMERGE
{\"backportTargets\":[\"8.8\"]}
ONMERGE-->","sha":"a69cb109e3d474b1e7cdf0f25bf4c3179a6a5de8","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","v8.8.0","v8.9.0"],"number":156718,"url":"https://github.com/elastic/kibana/pull/156718","mergeCommit":{"message":"Add
API Events to Endpoint Security Advanced Policy (#156718)\n\n##
Summary\r\n\r\nAdds a another advanced option for Endpoint to
Policy.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/42078554/236277606-3dd97609-733e-44b3-8230-60f9ef728adc.png)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n\r\n<!--ONMERGE
{\"backportTargets\":[\"8.8\"]}
ONMERGE-->","sha":"a69cb109e3d474b1e7cdf0f25bf4c3179a6a5de8"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156718","number":156718,"mergeCommit":{"message":"Add
API Events to Endpoint Security Advanced Policy (#156718)\n\n##
Summary\r\n\r\nAdds a another advanced option for Endpoint to
Policy.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/42078554/236277606-3dd97609-733e-44b3-8230-60f9ef728adc.png)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n\r\n<!--ONMERGE
{\"backportTargets\":[\"8.8\"]}
ONMERGE-->","sha":"a69cb109e3d474b1e7cdf0f25bf4c3179a6a5de8"}}]}]
BACKPORT-->

Co-authored-by: Gabriel Landau <42078554+gabriellandau@users.noreply.github.com>
jloleysens added a commit that referenced this pull request May 5, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
630343b 
* main: (153 commits)
  [Security Solution] {{state.signals_count}} Object not working (#156472) (#156707)
  [Synthetics] refresh data on visualization scrubbing (#156777)
  [RAM] Docs for slack improvements (#153885)
  [RAM] Alert search bar only KQL (#155947)
  [ML] Functional tests - stabilize export job tests (#156586)
  [Saved Search] Update saved search schema to allow empty `sort` arrays (#156769)
  [ML] Rename `curated` model type to `elastic` (#156684)
  [Discover] Enable sharing for text based languages (#156652)
  [api-docs] 2023-05-05 Daily api_docs build (#156781)
  Upgrade EUI to v77.2.2 (#155208)
  [RAM][Maintenance Window][8.8]Fix window maintenance workflow (#156427)
  [DOCS] Case file attachments (#156459)
  [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)
  [Enterprise Search] refactor(SearchApplications): rename telemetry ids (#156733)
  [Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)
  [Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured (#156233)
  [Logs onboarding] StepsFooter outside of main panel (#156686)
  [Security Solution] Add a migration to unmute custom Security Solution rules (#156593)
  [Enterprise Search][Behavioral Analytics] Update formulas (#156704)
  Add API Events to Endpoint Security Advanced Policy (#156718)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magermark magermark magermark approved these changes

@kevinlog kevinlog kevinlog approved these changes

@joeypoon joeypoon Awaiting requested review from joeypoon joeypoon was automatically assigned from elastic/security-defend-workflows

@gergoabraham gergoabraham Awaiting requested review from gergoabraham gergoabraham was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabriellandau @elasticmachine @kibana-ci @kibanamachine @magermark @kevinlog