Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Alert search bar only KQL #155947

Merged
merged 9 commits into from
May 5, 2023
Merged

[RAM] Alert search bar only KQL #155947

merged 9 commits into from
May 5, 2023

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Apr 26, 2023 •
edited by kibanamachine
Loading

Summary

Adding the props showQueryInput is fixing the layout of of the filters. We also wanted to make sure that our alert search bar can only work with KQL because we need to do some kind of validation on the field used in the search bar, therefore it will be easier to just use KueryNode for now.

Before:

Screenshot 2023-04-26 at 1 52 44 PM

After:

image

@XavierM XavierM added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 v8.9.0 labels Apr 26, 2023
@XavierM XavierM requested review from a team as code owners April 26, 2023 20:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@XavierM XavierM changed the title [RAM] Alert search only KQL [RAM] Alert search bar only KQL Apr 26, 2023
@XavierM
Copy link
Contributor Author

XavierM commented Apr 27, 2023

@elasticmachine merge upstream

@XavierM XavierM requested a review from Zacqary April 28, 2023 21:57
Zacqary
Zacqary approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stratoula
Copy link
Contributor

stratoula commented May 3, 2023 •
edited
Loading

@XavierM thanx for the contribution to the unified search. Can you also add a story about this prop to the unified search stories?

@XavierM XavierM enabled auto-merge (squash) May 4, 2023 19:39
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB +132.0B
unifiedSearch 268.4KB 268.6KB +177.0B
total +309.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanx for adding the storybook, changes LGTM

@XavierM XavierM merged commit af7e34a into elastic:main May 5, 2023
@kibanamachine kibanamachine mentioned this pull request May 5, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 5, 2023
@XavierM
[RAM] Alert search bar only KQL (elastic#155947)
19946d2 
## Summary

Adding the props `showQueryInput` is fixing the layout of of the
filters. We also wanted to make sure that our alert search bar can only
work with KQL because we need to do some kind of validation on the field
used in the search bar, therefore it will be easier to just use
KueryNode for now.

### Before:
<img width="754" alt="Screenshot 2023-04-26 at 1 52 44 PM"
src="https://user-images.githubusercontent.com/189600/234698078-612f03be-3331-41ab-a2d9-80f6cd767043.png">

### After:
<img width="749" alt="image"
src="https://user-images.githubusercontent.com/189600/234697735-abafc15f-5562-42a0-aeb9-638129d70120.png">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit af7e34a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit that referenced this pull request May 5, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
630343b 
* main: (153 commits)
  [Security Solution] {{state.signals_count}} Object not working (#156472) (#156707)
  [Synthetics] refresh data on visualization scrubbing (#156777)
  [RAM] Docs for slack improvements (#153885)
  [RAM] Alert search bar only KQL (#155947)
  [ML] Functional tests - stabilize export job tests (#156586)
  [Saved Search] Update saved search schema to allow empty `sort` arrays (#156769)
  [ML] Rename `curated` model type to `elastic` (#156684)
  [Discover] Enable sharing for text based languages (#156652)
  [api-docs] 2023-05-05 Daily api_docs build (#156781)
  Upgrade EUI to v77.2.2 (#155208)
  [RAM][Maintenance Window][8.8]Fix window maintenance workflow (#156427)
  [DOCS] Case file attachments (#156459)
  [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)
  [Enterprise Search] refactor(SearchApplications): rename telemetry ids (#156733)
  [Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)
  [Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured (#156233)
  [Logs onboarding] StepsFooter outside of main panel (#156686)
  [Security Solution] Add a migration to unmute custom Security Solution rules (#156593)
  [Enterprise Search][Behavioral Analytics] Update formulas (#156704)
  Add API Events to Endpoint Security Advanced Policy (#156718)
  ...
kibanamachine added a commit that referenced this pull request May 5, 2023
@kibanamachine @XavierM
[8.8] [RAM] Alert search bar only KQL (#155947) (#156793)
d762daa 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[RAM] Alert search bar only KQL
(#155947)](#155947)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Xavier
Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2023-05-05T07:32:13Z","message":"[RAM]
Alert search bar only KQL (#155947)\n\n## Summary\r\n\r\nAdding the
props `showQueryInput` is fixing the layout of of the\r\nfilters. We
also wanted to make sure that our alert search bar can only\r\nwork with
KQL because we need to do some kind of validation on the field\r\nused
in the search bar, therefore it will be easier to just use\r\nKueryNode
for now.\r\n\r\n### Before:\r\n<img width=\"754\" alt=\"Screenshot
2023-04-26 at 1 52 44
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/234698078-612f03be-3331-41ab-a2d9-80f6cd767043.png\">\r\n\r\n\r\n###
After:\r\n<img width=\"749\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/234697735-abafc15f-5562-42a0-aeb9-638129d70120.png\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"af7e34a2ba3c4d0bd4a2e46979f6b96bada439ef","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v8.8.0","v8.9.0"],"number":155947,"url":"https://github.com/elastic/kibana/pull/155947","mergeCommit":{"message":"[RAM]
Alert search bar only KQL (#155947)\n\n## Summary\r\n\r\nAdding the
props `showQueryInput` is fixing the layout of of the\r\nfilters. We
also wanted to make sure that our alert search bar can only\r\nwork with
KQL because we need to do some kind of validation on the field\r\nused
in the search bar, therefore it will be easier to just use\r\nKueryNode
for now.\r\n\r\n### Before:\r\n<img width=\"754\" alt=\"Screenshot
2023-04-26 at 1 52 44
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/234698078-612f03be-3331-41ab-a2d9-80f6cd767043.png\">\r\n\r\n\r\n###
After:\r\n<img width=\"749\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/234697735-abafc15f-5562-42a0-aeb9-638129d70120.png\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"af7e34a2ba3c4d0bd4a2e46979f6b96bada439ef"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155947","number":155947,"mergeCommit":{"message":"[RAM]
Alert search bar only KQL (#155947)\n\n## Summary\r\n\r\nAdding the
props `showQueryInput` is fixing the layout of of the\r\nfilters. We
also wanted to make sure that our alert search bar can only\r\nwork with
KQL because we need to do some kind of validation on the field\r\nused
in the search bar, therefore it will be easier to just use\r\nKueryNode
for now.\r\n\r\n### Before:\r\n<img width=\"754\" alt=\"Screenshot
2023-04-26 at 1 52 44
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/234698078-612f03be-3331-41ab-a2d9-80f6cd767043.png\">\r\n\r\n\r\n###
After:\r\n<img width=\"749\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/234697735-abafc15f-5562-42a0-aeb9-638129d70120.png\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"af7e34a2ba3c4d0bd4a2e46979f6b96bada439ef"}}]}]
BACKPORT-->

Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zacqary Zacqary Zacqary approved these changes

@stratoula stratoula stratoula approved these changes

@ersin-erdal ersin-erdal Awaiting requested review from ersin-erdal

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XavierM @elasticmachine @stratoula @kibana-ci @kibanamachine @Zacqary