Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Add telemetry to ELSER deployment buttons + error #156545

Merged
merged 5 commits into from
May 4, 2023
Merged

[Enterprise Search] Add telemetry to ELSER deployment buttons + error #156545

merged 5 commits into from
May 4, 2023

Conversation

demjened
Copy link
Contributor

@demjened demjened commented May 3, 2023 •
edited by kibanamachine
Loading

Summary

This PR adds telemetry to ELSER deployment actions (download, start deployment) and errors.

The ELSER 1-click workflow was tested manually to ensure there's no regression.

@demjened demjened added Team:EnterpriseSearch v8.8.0 v8.9.0 release_note:skip Skip the PR/issue when compiling release notes labels May 3, 2023
demjened
demjened commented May 3, 2023
View reviewed changes
...ise_search_content/components/search_index/pipelines/ml_inference/text_expansion_callout.tsx
@@ -327,6 +333,7 @@ export const ModelStarted = ({

export const TextExpansionCallOut: React.FC<TextExpansionCallOutProps> = (props) => {
const { dismiss, isDismissable, show } = useTextExpansionCallOutData(props);
const { ingestionMethod } = useValues(IndexViewLogic);
Copy link
Contributor Author

@demjened demjened May 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method of importing ingestionMethod copied from here.

demjened
demjened commented May 3, 2023
View reviewed changes
...rise_search_content/components/search_index/pipelines/ml_inference/text_expansion_errors.tsx

export const TextExpansionErrors = ({ error }: { error: { title: string; message: string } }) => {
const { http } = useValues(HttpLogic);

return (
<>
<SendEnterpriseSearchTelemetry action="error" metric="textExpansionModel-error" />
Copy link
Contributor Author

@demjened demjened May 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Per convo with @TattdCodeMonkey I think this is the correct way to send metrics when an error pops up, but let me know if it isn't.
  2. Not sure about the metric name, the only references I found use short and generic metric names.

@demjened demjened marked this pull request as ready for review May 3, 2023 16:07
@demjened demjened requested a review from a team May 3, 2023 16:07
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB +421.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@demjened demjened merged commit 0742a0c into elastic:main May 4, 2023
@kibanamachine kibanamachine mentioned this pull request May 4, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 4, 2023
@demjened
[Enterprise Search] Add telemetry to ELSER deployment buttons + error (…
7556de5 
…elastic#156545)

## Summary

This PR adds telemetry to ELSER deployment actions (download, start
deployment) and errors.

The ELSER 1-click workflow was tested manually to ensure there's no
regression.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0742a0c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 4, 2023
@kibanamachine @demjened
[8.8] [Enterprise Search] Add telemetry to ELSER deployment buttons +…
69c2876 
… error (#156545) (#156751)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Add telemetry to ELSER deployment buttons + error
(#156545)](#156545)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Adam
Demjen","email":"demjened@gmail.com"},"sourceCommit":{"committedDate":"2023-05-04T20:21:51Z","message":"[Enterprise
Search] Add telemetry to ELSER deployment buttons + error
(#156545)\n\n## Summary\r\n\r\nThis PR adds telemetry to ELSER
deployment actions (download, start\r\ndeployment) and
errors.\r\n\r\nThe ELSER 1-click workflow was tested manually to ensure
there's no\r\nregression.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0742a0c4c430b6425a2afa1f3959bcfc0cae474c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156545,"url":"https://github.com/elastic/kibana/pull/156545","mergeCommit":{"message":"[Enterprise
Search] Add telemetry to ELSER deployment buttons + error
(#156545)\n\n## Summary\r\n\r\nThis PR adds telemetry to ELSER
deployment actions (download, start\r\ndeployment) and
errors.\r\n\r\nThe ELSER 1-click workflow was tested manually to ensure
there's no\r\nregression.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0742a0c4c430b6425a2afa1f3959bcfc0cae474c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156545","number":156545,"mergeCommit":{"message":"[Enterprise
Search] Add telemetry to ELSER deployment buttons + error
(#156545)\n\n## Summary\r\n\r\nThis PR adds telemetry to ELSER
deployment actions (download, start\r\ndeployment) and
errors.\r\n\r\nThe ELSER 1-click workflow was tested manually to ensure
there's no\r\nregression.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0742a0c4c430b6425a2afa1f3959bcfc0cae474c"}}]}]
BACKPORT-->

Co-authored-by: Adam Demjen <demjened@gmail.com>
jloleysens added a commit that referenced this pull request May 5, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
630343b 
* main: (153 commits)
  [Security Solution] {{state.signals_count}} Object not working (#156472) (#156707)
  [Synthetics] refresh data on visualization scrubbing (#156777)
  [RAM] Docs for slack improvements (#153885)
  [RAM] Alert search bar only KQL (#155947)
  [ML] Functional tests - stabilize export job tests (#156586)
  [Saved Search] Update saved search schema to allow empty `sort` arrays (#156769)
  [ML] Rename `curated` model type to `elastic` (#156684)
  [Discover] Enable sharing for text based languages (#156652)
  [api-docs] 2023-05-05 Daily api_docs build (#156781)
  Upgrade EUI to v77.2.2 (#155208)
  [RAM][Maintenance Window][8.8]Fix window maintenance workflow (#156427)
  [DOCS] Case file attachments (#156459)
  [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)
  [Enterprise Search] refactor(SearchApplications): rename telemetry ids (#156733)
  [Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)
  [Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured (#156233)
  [Logs onboarding] StepsFooter outside of main panel (#156686)
  [Security Solution] Add a migration to unmute custom Security Solution rules (#156593)
  [Enterprise Search][Behavioral Analytics] Update formulas (#156704)
  Add API Events to Endpoint Security Advanced Policy (#156718)
  ...
@demjened demjened deleted the demjened/elser-telemetry branch May 5, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@demjened @kibana-ci @kibanamachine @TattdCodeMonkey