Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add missing endpoints to openApi specs #147452

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

criamico
Copy link
Contributor

Summary

Closes #136807

Updating the following endpoints, currently undocumented:

  • POST /api/fleet/health_check
  • GET /api/fleet/agent_policies/{agentPolicyId}/full
  • GET /api/fleet/agent_policies/{agentPolicyId}/download
  • POST /api/fleet/agents/actions/{actionId}/cancel
  • GET /api/fleet/agents/{agentId}/uploads
  • GET /api/fleet/agents/files/{fileId}/{fileName}
  • GET /api/fleet/kubernetes

@criamico criamico self-assigned this Dec 13, 2022
@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team skip-ci release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Dec 13, 2022
@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico criamico removed the skip-ci label Dec 13, 2022
@criamico criamico marked this pull request as ready for review December 13, 2022 16:59
@criamico criamico requested a review from a team as a code owner December 13, 2022 16:59
@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
fleet 19 20 +1
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit f2422ce into elastic:main Dec 14, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 14, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 14, 2022
* main: (21 commits)
  [Profiling] Remove link to 'Other' bucket (elastic#147523)
  [Synthetics UI] Add missing configuration options to the add/edit monitor forms (elastic#147265)
  [DOCS] Updates what's new pages (elastic#147483)
  [Fleet][Endpoint][RBAC V2] Update fleet router and config to allow API access via RBAC controls (elastic#145361)
  [Guided onboarding] Update guide IDs (elastic#147348)
  [Synthetics] Add synthetics settings alerting default (elastic#147339)
  [Security Solution][Endpoint] Fix Policy form being displayed as Read Only when displayed in Fleet pages (elastic#147212)
  [Cases] Save draft user comment (elastic#146327)
  [API Docs] Fix `--plugin` filter (elastic#147500)
  [Fleet] added a logic to use `destinationId` when tagging imported SOs (elastic#147439)
  Do not skip UPDATE_TARGET_MAPPINGS if upgrading to a newer stack version (elastic#147503)
  [Discover] Validate if Data View time field exists on Alert creation / editing (elastic#146324)
  [Discover] Fix Discover navigation from Lens embeddable (elastic#147000)
  Allow users to Update API Keys (elastic#146237)
  Update dependency xstate to ^4.35.0 (main) (elastic#147463)
  [Behavioral Analytics] Remove feature flag to hide functionality (elastic#147429)
  [Fleet] Add agent policy `inactivity_timeout`experimental setting (elastic#147432)
  [APM] Switching service groups from grid to flex layout (elastic#147448)
  [Fleet] Add missing endpoints to openApi specs (elastic#147452)
  [AO] Allow providing custom time range for Alert Summary Widget (elastic#147253)
  ...
nreese pushed a commit to nreese/kibana that referenced this pull request Dec 16, 2022
## Summary

Closes elastic#136807

Updating the following endpoints, currently undocumented:

- `POST /api/fleet/health_check`
- `GET /api/fleet/agent_policies/{agentPolicyId}/full`
- `GET /api/fleet/agent_policies/{agentPolicyId}/download`
- `POST /api/fleet/agents/actions/{actionId}/cancel`
- `GET /api/fleet/agents/{agentId}/uploads`
- `GET /api/fleet/agents/files/{fileId}/{fileName}`
- `GET /api/fleet/kubernetes`

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Document missing APIs in OpenAPI spec
4 participants