[AO] Allow providing custom time range for Alert Summary Widget #147253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
kdelemme
reviewed
Dec 8, 2022
...cation/sections/rule_details/components/alert_summary/components/alert_summary_widget_ui.tsx
Outdated
Show resolved
Hide resolved
| @@ -108,6 +110,7 @@ export function RuleDetailsPage() { | |||
| const [editFlyoutVisible, setEditFlyoutVisible] = useState<boolean>(false); | |||
| const [isRuleEditPopoverOpen, setIsRuleEditPopoverOpen] = useState(false); | |||
| const [esQuery, setEsQuery] = useState<{ bool: BoolQuery }>(); | |||
| const [defaultAlertTimeRange] = useState(getDefaultAlertSummaryTimeRange); | |||
There was a problem hiding this comment.
Do we need to use a state for this? Can it be just a variable in this scope, or a constant in the module?
There was a problem hiding this comment.
The reason for having this state is to run getAbsoluteTimeRange only once during the rendering of this component. getAbsoluteTimeRange will return the absolute time for the last 30 days at the time of the execution and I didn't want this value to be created more than once in this component but I also didn't want to have it created when the module is loaded so I used the state in this case.
There was a problem hiding this comment.
nit - I also saw that people use useRef to do that to avoid the state
There was a problem hiding this comment.
In this case, I'll keep it in the state to be able to refresh it in case we want to.
Co-authored-by: Kevin Delemme <kdelemme@gmail.com>
1 task
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
XavierM
approved these changes
Dec 13, 2022
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 14, 2022
* main: (21 commits) [Profiling] Remove link to 'Other' bucket (elastic#147523) [Synthetics UI] Add missing configuration options to the add/edit monitor forms (elastic#147265) [DOCS] Updates what's new pages (elastic#147483) [Fleet][Endpoint][RBAC V2] Update fleet router and config to allow API access via RBAC controls (elastic#145361) [Guided onboarding] Update guide IDs (elastic#147348) [Synthetics] Add synthetics settings alerting default (elastic#147339) [Security Solution][Endpoint] Fix Policy form being displayed as Read Only when displayed in Fleet pages (elastic#147212) [Cases] Save draft user comment (elastic#146327) [API Docs] Fix `--plugin` filter (elastic#147500) [Fleet] added a logic to use `destinationId` when tagging imported SOs (elastic#147439) Do not skip UPDATE_TARGET_MAPPINGS if upgrading to a newer stack version (elastic#147503) [Discover] Validate if Data View time field exists on Alert creation / editing (elastic#146324) [Discover] Fix Discover navigation from Lens embeddable (elastic#147000) Allow users to Update API Keys (elastic#146237) Update dependency xstate to ^4.35.0 (main) (elastic#147463) [Behavioral Analytics] Remove feature flag to hide functionality (elastic#147429) [Fleet] Add agent policy `inactivity_timeout`experimental setting (elastic#147432) [APM] Switching service groups from grid to flex layout (elastic#147448) [Fleet] Add missing endpoints to openApi specs (elastic#147452) [AO] Allow providing custom time range for Alert Summary Widget (elastic#147253) ...
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Dec 16, 2022
…tic#147253) Resolves elastic#139489 ## 📝 Summary Allow time range filter to be provided by consumer for Alert Summary Widget. ## 🧪 How to test The functionality of the Alert Summary Widget has not been changed, so Alert Summary Widget should have the same information as before. You can check if the numbers that you see in the widget match the number of alerts in the alert table. Co-authored-by: Kevin Delemme <kdelemme@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #139489
📝 Summary
Allow time range filter to be provided by consumer for Alert Summary Widget.
🧪 How to test
The functionality of the Alert Summary Widget has not been changed, so Alert Summary Widget should have the same information as before. You can check if the numbers that you see in the widget match the number of alerts in the alert table.