[Fleet] Add agent policy `inactivity_timeout`experimental setting #147432

hop-dev · 2022-12-13T12:05:51Z

Summary

Add a new agent policy setting inactivity_timeout, this is behind a feature flag for now and doesn't actually do anything until later PRs are merged, just trying to keep the PRs neat and small :)

Add this to your kibana config to see the new UI element:

xpack.fleet.enableExperimental: 
    - inactivityTimeout

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)

elasticmachine · 2022-12-13T12:05:58Z

Pinging @elastic/fleet (Team:Fleet)

nchaulet

Looks good to me 🚀

kibana-ci · 2022-12-13T15:31:54Z

💚 Build Succeeded

Buildkite Build
Commit: 3a5ae02

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	922	923	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	897.6KB	898.9KB	+1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	120.5KB	120.6KB	+21.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id	before	after	diff
`ingest-agent-policies`	19	20	+1

Unknown metric groups

API count

id	before	after	diff
`fleet`	1027	1028	+1

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	60	67	+7
`osquery`	109	115	+6
`securitySolution`	445	451	+6
total			+21

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	69	76	+7
`osquery`	110	117	+7
`securitySolution`	521	527	+6
total			+22

History

💔 Build #94330 failed cf952bd
💔 Build #94295 failed 6478d1f301e6d14fda19f74789847ad437149265

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

afharo · 2022-12-14T10:35:27Z

x-pack/plugins/fleet/server/saved_objects/index.ts

@@ -102,6 +102,7 @@ const getSavedObjectTypes = (
        is_default_fleet_server: { type: 'boolean' },
        status: { type: 'keyword' },
        unenroll_timeout: { type: 'integer' },
+        inactivity_timeout: { type: 'integer' },


Q: Are we planning to query this field? If not, I'd add index: false to avoid mapping field explosion in the .kibana index.

Suggested change

inactivity_timeout: { type: 'integer' },

inactivity_timeout: { type: 'integer', index: false },

Hey, thanks for the comment, I'll be searching and aggregating on it in a following PR 👍

Awesome! Thanks for confirming! Changes LGTM then

* main: (21 commits) [Profiling] Remove link to 'Other' bucket (elastic#147523) [Synthetics UI] Add missing configuration options to the add/edit monitor forms (elastic#147265) [DOCS] Updates what's new pages (elastic#147483) [Fleet][Endpoint][RBAC V2] Update fleet router and config to allow API access via RBAC controls (elastic#145361) [Guided onboarding] Update guide IDs (elastic#147348) [Synthetics] Add synthetics settings alerting default (elastic#147339) [Security Solution][Endpoint] Fix Policy form being displayed as Read Only when displayed in Fleet pages (elastic#147212) [Cases] Save draft user comment (elastic#146327) [API Docs] Fix `--plugin` filter (elastic#147500) [Fleet] added a logic to use `destinationId` when tagging imported SOs (elastic#147439) Do not skip UPDATE_TARGET_MAPPINGS if upgrading to a newer stack version (elastic#147503) [Discover] Validate if Data View time field exists on Alert creation / editing (elastic#146324) [Discover] Fix Discover navigation from Lens embeddable (elastic#147000) Allow users to Update API Keys (elastic#146237) Update dependency xstate to ^4.35.0 (main) (elastic#147463) [Behavioral Analytics] Remove feature flag to hide functionality (elastic#147429) [Fleet] Add agent policy `inactivity_timeout`experimental setting (elastic#147432) [APM] Switching service groups from grid to flex layout (elastic#147448) [Fleet] Add missing endpoints to openApi specs (elastic#147452) [AO] Allow providing custom time range for Alert Summary Widget (elastic#147253) ...

…astic#147432) ## Summary Part of elastic#143455. Add a new agent policy setting `inactivity_timeout`, this is behind a feature flag for now and doesn't actually do anything until later PRs are merged, just trying to keep the PRs neat and small :) <img width="1233" alt="Screenshot 2022-12-13 at 12 05 09" src="https://user-images.githubusercontent.com/3315046/207313388-6ee43e3b-b935-4ac9-a7bf-ebe386abe8ac.png"> Add this to your kibana config to see the new UI element: ``` xpack.fleet.enableExperimental: - inactivityTimeout ``` ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))

kibanamachine · 2023-12-30T21:48:55Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 147432 locally

kibanamachine · 2024-01-02T21:48:50Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 147432 locally

[Fleet] Add agent policy experimental setting

09a1d48

hop-dev requested a review from a team as a code owner December 13, 2022 12:05

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 13, 2022

hop-dev self-assigned this Dec 13, 2022

hop-dev added the release_note:skip Skip the PR/issue when compiling release notes label Dec 13, 2022

nchaulet approved these changes Dec 13, 2022

View reviewed changes

hop-dev added 3 commits December 13, 2022 13:57

add API docs

c0b2920

delete file added in error

4403dbc

fix tests

cf952bd

hop-dev force-pushed the 143455-add-experimental-inactivity-timeout branch from 6478d1f to cf952bd Compare December 13, 2022 14:04

hop-dev requested a review from a team as a code owner December 13, 2022 14:04

fix test renderer

3a5ae02

hop-dev enabled auto-merge (squash) December 13, 2022 15:32

afharo reviewed Dec 14, 2022

View reviewed changes

afharo approved these changes Dec 14, 2022

View reviewed changes

hop-dev merged commit 1b699fc into elastic:main Dec 14, 2022

hop-dev deleted the 143455-add-experimental-inactivity-timeout branch December 14, 2022 11:20

juliaElastic added the v8.7.0 label Feb 17, 2023

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 30, 2023

kpollich added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jan 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Add agent policy `inactivity_timeout`experimental setting #147432

[Fleet] Add agent policy `inactivity_timeout`experimental setting #147432

hop-dev commented Dec 13, 2022

elasticmachine commented Dec 13, 2022

nchaulet left a comment

kibana-ci commented Dec 13, 2022

API count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

afharo Dec 14, 2022

hop-dev Dec 14, 2022

afharo Dec 14, 2022

kibanamachine commented Dec 30, 2023

kibanamachine commented Jan 2, 2024

	inactivity_timeout: { type: 'integer' },
	inactivity_timeout: { type: 'integer', index: false },

[Fleet] Add agent policy inactivity_timeoutexperimental setting #147432

[Fleet] Add agent policy inactivity_timeoutexperimental setting #147432

Conversation

hop-dev commented Dec 13, 2022

Summary

Checklist

elasticmachine commented Dec 13, 2022

nchaulet left a comment

Choose a reason for hiding this comment

kibana-ci commented Dec 13, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

Saved Objects .kibana field count

API count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

afharo Dec 14, 2022

Choose a reason for hiding this comment

hop-dev Dec 14, 2022

Choose a reason for hiding this comment

afharo Dec 14, 2022

Choose a reason for hiding this comment

kibanamachine commented Dec 30, 2023

kibanamachine commented Jan 2, 2024

[Fleet] Add agent policy `inactivity_timeout`experimental setting #147432

[Fleet] Add agent policy `inactivity_timeout`experimental setting #147432