-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data views] Support include_unmapped in field caps request #146953
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code only review, LGTM! Only thing is I'm not sure it closes #144772 if that issue was intended for the actual getFieldsForIndexPattern
implementation (not clear to me from the issue description).
@kertal @jughosta Should we close #144772 with this and spin off another issue for the getFieldsForIndexPattern
implementation, or just link this PR to the existing issue and leave it open?
@davismcphee Its unclear to me what further work is needed so I'll let others make that decision. Past that, |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Allows data views API
getFieldsForWildcard
to supportinclude_unmapped
param.Closes #144772