Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Support include_unmapped in field caps request #146953

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Dec 4, 2022

Summary

Allows data views API getFieldsForWildcard to support include_unmapped param.

Closes #144772

@mattkime mattkime added v8.7.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes labels Dec 4, 2022
@mattkime mattkime changed the title grab unmapped fields [data views] Support include_unmapped in field caps request Dec 5, 2022
@mattkime mattkime added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Dec 5, 2022
@mattkime mattkime marked this pull request as ready for review December 5, 2022 13:40
@mattkime mattkime requested review from a team as code owners December 5, 2022 13:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only review, LGTM! Only thing is I'm not sure it closes #144772 if that issue was intended for the actual getFieldsForIndexPattern implementation (not clear to me from the issue description).

@kertal @jughosta Should we close #144772 with this and spin off another issue for the getFieldsForIndexPattern implementation, or just link this PR to the existing issue and leave it open?

@mattkime
Copy link
Contributor Author

mattkime commented Dec 5, 2022

@davismcphee Its unclear to me what further work is needed so I'll let others make that decision. Past that, getFieldsForIndexPattern supports include_unmapped - updating GetFieldsOptions was the change closest to getFieldsForIndexPattern, the rest is just passing the argument through to the request.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2553 2555 +2
dataViews 227 228 +1
total +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViews 45.5KB 45.5KB +37.0B
Unknown metric groups

API count

id before after diff
data 3265 3267 +2
dataViews 1021 1022 +1
total +3

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Dec 6, 2022

#144772 can be closed, the follow up task would be to integrate in the the Unified Field List, so the follow up issue needs to be written, fleshed out, right @jughosta ?
#145796

@jughosta
Copy link
Contributor

jughosta commented Dec 6, 2022

Yes, we can close #144772 and keep #145796

Thanks for implementing the change!

@mattkime mattkime merged commit bf103ef into elastic:main Dec 6, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data views] Implement unmappedFields option for getFieldsForIndexPattern
8 participants