Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Decouple sidebar from search results by fetching unmapped fields too #145796

Closed
kertal opened this issue Nov 21, 2022 · 3 comments
Closed

[Discover] Decouple sidebar from search results by fetching unmapped fields too #145796

kertal opened this issue Nov 21, 2022 · 3 comments
Assignees
@mattkime
Labels
chore Feature:Discover Discover Application Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Nov 21, 2022 •
edited by jughosta
Loading

Once #144772 is implemented, allowing to get also unmappedFields when using getFieldsForIndexPattern it should be integrated in Discover.

Currently, the sidebar is waiting for the fetched documents before it renders https://github.com/elastic/kibana/blob/main/src/plugins/discover/public/application/main/components/sidebar/discover_sidebar_responsive.tsx#L167
That was necessary to find unmapped fields. The recently implemented "unmappedFields" can be used instead so we have a full list of fields (mapped and unmapped) in https://github.com/elastic/kibana/blob/main/src/plugins/discover/public/application/main/components/sidebar/lib/sidebar_reducer.ts#L98.
@kertal kertal added chore Feature:Discover Discover Application loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal mentioned this issue Dec 6, 2022
Merged
@jughosta jughosta changed the title [Discover] Integrate unmappedFields option for getFieldsForIndexPattern [Discover] Decouple sidebar from search results by fetching unmapped fields too Dec 6, 2022
@kertal kertal added the Feature:UnifiedFieldList The unified field list component used by Lens & Discover label Dec 21, 2022
@mattkime mattkime mentioned this issue Jan 23, 2023
Closed
9 tasks
@kertal
Copy link
Member Author

kertal commented Mar 29, 2023

@mattkime I'll close this, adding context we can't implement it, because field_caps don't support getting unmappedFields for our purpose, ok?

@kertal
Copy link
Member Author

kertal commented Mar 30, 2023

Closing due to elastic/elasticsearch#94888

@kertal kertal closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
chore Feature:Discover Discover Application Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[discover] use field caps api to load field list mattkime/kibana
3 participants
@mattkime @kertal @elasticmachine