Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data views] Implement unmappedFields option for getFieldsForIndexPattern #144772

Closed
Tracked by #137779
kertal opened this issue Nov 8, 2022 · 1 comment · Fixed by #146953
Closed
Tracked by #137779

[Data views] Implement unmappedFields option for getFieldsForIndexPattern #144772

kertal opened this issue Nov 8, 2022 · 1 comment · Fixed by #146953
Assignees
@mattkime
Labels
8.7 candidate Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Nov 8, 2022

For the UnifiedFieldList component, we need an option for fetching unmapped Fields additionally using getFieldsForIndexPattern.

kibana/src/plugins/data_views/common/data_views/data_views.ts

Lines 510 to 520 in bb67548

/**
* Get field list by providing an index patttern (or spec).
* @param options options for getting field list
* @returns FieldSpec[]
*/
getFieldsForIndexPattern = async (
indexPattern: DataView | DataViewSpec,
options?: GetFieldsOptions
) =>
this.getFieldsForWildcard({
type: indexPattern.type,

This surfaced in PR #144412, where we implemented a workaround for this. Elasticsearch field_caps API supports using include_unmapped

https://www.elastic.co/guide/en/elasticsearch/reference/current/search-field-caps.html
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added Feature:Data Views Data Views code and UI - index patterns before 8.0 and removed Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 8, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 8, 2022
@kertal kertal added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Feature:Discover Discover Application labels Nov 8, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 8, 2022
@kertal kertal added 8.7 candidate loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Nov 8, 2022
@kertal kertal changed the title [Data views] Implement unmappedFields options for getFieldsForIndexPattern [Data views] Implement unmappedFields option for getFieldsForIndexPattern Nov 8, 2022
This was referenced Nov 18, 2022
Closed
Closed
@mattkime mattkime mentioned this issue Dec 5, 2022
Merged
mattkime added a commit that referenced this issue Dec 6, 2022
@mattkime
[data views] Support include_unmapped in field caps request (#146953)
bf103ef 
## Summary

Allows data views API `getFieldsForWildcard` to support
`include_unmapped` param.

Closes #144772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
8.7 candidate Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[data views] Support include_unmapped in field caps request mattkime/kibana
3 participants
@mattkime @kertal @elasticmachine