Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] Revert "Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)" (#117613) #117751

Merged
merged 2 commits into from
Nov 10, 2021
Merged

[8.0] Revert "Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)" (#117613) #117751

merged 2 commits into from
Nov 10, 2021

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Nov 5, 2021 •
edited
Loading

Backports the following commits to 8.0:

@cqliu1 cqliu1 added the backport label Nov 5, 2021
@cqliu1 cqliu1 enabled auto-merge (squash) November 5, 2021 22:18
@cqliu1 cqliu1 force-pushed the backport/8.0/pr-117613 branch from 0571d5f to 01c76a2 Compare November 9, 2021 16:32
@cqliu1
Copy link
Contributor Author

cqliu1 commented Nov 9, 2021

@elasticmachine merge upstream

1 similar comment
@cqliu1
Copy link
Contributor Author

cqliu1 commented Nov 9, 2021

@elasticmachine merge upstream

@cqliu1 cqliu1 disabled auto-merge November 9, 2021 18:17
@cqliu1 @kibanamachine
Revert "Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elas…
8a0e544 
…tic#116527)" (elastic#117613)

* Revert "Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elastic#116527)"

This reverts commit 9e6e845.

* Fix ts error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@cqliu1 cqliu1 force-pushed the backport/8.0/pr-117613 branch from 11efe7b to 8a0e544 Compare November 10, 2021 17:55
@cqliu1
Copy link
Contributor Author

cqliu1 commented Nov 10, 2021

@elasticmachine merge upstream

@cqliu1 cqliu1 enabled auto-merge (squash) November 10, 2021 19:43
@cqliu1 cqliu1 disabled auto-merge November 10, 2021 19:43
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1034 1046 +12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
presentationUtil 234 243 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 970.6KB 1003.6KB +33.0KB
dashboard 275.6KB 275.7KB +2.0B
total +33.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 17.0KB 17.4KB +415.0B
presentationUtil 61.3KB 62.5KB +1.2KB
total +1.6KB
Unknown metric groups

API count

id before after diff
presentationUtil 262 271 +9

References to deprecated APIs

id before after diff
canvas 67 70 +3

History

  • 💚 Build #5495 succeeded 11efe7ba177b2a13d9f741f90cc6d7428867842f
  • 💔 Build #5447 failed 97321070ccdcdcbddd1cd962e6c175f669c8ecb1
  • 💔 Build #4810 failed 0571d5fd7a8f70333fda46c075b92497526c5b26

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit a4dd96a into elastic:8.0 Nov 10, 2021
@cqliu1 cqliu1 deleted the backport/8.0/pr-117613 branch November 10, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cqliu1 @kibanamachine