Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Canvas] By-Value Embeddables (#113827)" #116527

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Revert "[Canvas] By-Value Embeddables (#113827)" #116527

merged 1 commit into from
Oct 28, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Oct 27, 2021 •
edited
Loading

Sorry folks, but when this PR was merged CI started to take almost an hour longer. We've spent some time trying to figure out why, but the best answer we've been able to come up with so far is that CI was fast before this PR. I'm going to help @cqliu1 as much as I can figure out why this is happening, but for now we need to revert this PR.

@spalger spalger mentioned this pull request Oct 27, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1082 1070 -12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
presentationUtil 243 234 -9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB -33.0KB
dashboard 289.5KB 289.5KB -2.0B
total -33.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 17.6KB 17.3KB -275.0B
presentationUtil 68.0KB 66.6KB -1.4KB
total -1.6KB
Unknown metric groups

API count

id before after diff
presentationUtil 271 262 -9

References to deprecated APIs

id before after diff
canvas 70 67 -3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 28, 2021
@spalger spalger marked this pull request as ready for review October 28, 2021 01:36
@spalger spalger requested review from a team as code owners October 28, 2021 01:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 28, 2021
@spalger spalger merged commit 9e6e845 into elastic:master Oct 28, 2021
@spalger spalger deleted the revert-113827 branch October 28, 2021 01:38
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

@spalger spalger mentioned this pull request Oct 28, 2021
Merged
11 tasks
@kibanamachine kibanamachine mentioned this pull request Oct 28, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 28, 2021
@spalger @kibanamachine
Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elastic#116527)
9260184 
This reverts commit bacd7f9.

Co-authored-by: spalger <spalger@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

academo pushed a commit to academo/kibana that referenced this pull request Oct 28, 2021
@spalger
Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elastic#116527)
677f8db 
This reverts commit bacd7f9.

Co-authored-by: spalger <spalger@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 29, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@spalger spalger added the backport:skip This commit does not require backporting label Nov 1, 2021
spalger added a commit that referenced this pull request Nov 1, 2021
@kibanamachine @spalger
[8.0] Revert "[Canvas] By-Value Embeddables (#113827)" (#116527) (#11…
4359e70 
…6539)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Spencer <email@spalger.com>
@spalger spalger removed backport:skip This commit does not require backporting backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 1, 2021
@spalger spalger added backport:skip This commit does not require backporting backported and removed backport:skip This commit does not require backporting labels Nov 1, 2021
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Nov 5, 2021
@cqliu1
Revert "Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elas…
8ecc714 
…tic#116527)"

This reverts commit 9e6e845.
cqliu1 added a commit that referenced this pull request Nov 5, 2021
@cqliu1 @kibanamachine
Revert "Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)" (#…
57a53db 
…117613)

* Revert "Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)"

This reverts commit 9e6e845.

* Fix ts error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@cqliu1 cqliu1 mentioned this pull request Nov 5, 2021
Merged
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Nov 10, 2021
@cqliu1 @kibanamachine
Revert "Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elas…
8a0e544 
…tic#116527)" (elastic#117613)

* Revert "Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elastic#116527)"

This reverts commit 9e6e845.

* Fix ts error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cqliu1 added a commit that referenced this pull request Nov 10, 2021
@cqliu1 @kibanamachine
Revert "Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)" (#…
a4dd96a 
…117613) (#117751)

* Revert "Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)"

This reverts commit 9e6e845.

* Fix ts error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backported release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalger @kibanamachine @elasticmachine