[Canvas] By-Value Embeddables

[cqliu1]

Summary

This reverts commit 9e6e845, which restores the changes from #113827.

I determined that #113827 was not the cause of the hour long CI delays, which was the reason this feature was originally reverted. The CI delays were resolved with this fix #116717 and were not related to the Canvas support for by-value embeddables feature.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[ThomThomson]

Great to see this getting back in! LGTM!

[cqliu1]

@elasticmachine merge upstream

[cqliu1]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 48a6bb1
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
canvas	1034	1046	+12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
presentationUtil	234	243	+9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
canvas	971.5KB	1004.5KB	+33.0KB
dashboard	276.4KB	276.4KB	+2.0B
total			+33.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
canvas	17.0KB	17.4KB	+415.0B
presentationUtil	61.3KB	62.5KB	+1.2KB
total			+1.6KB

Unknown metric groups

API count

id	before	after	diff
presentationUtil	262	271	+9

References to deprecated APIs

id	before	after	diff
canvas	67	70	+3

History

• 💔 Build #4772 failed e52b0eb
• 💔 Build #4752 failed 728f133828250352932362a864e65f47e8fc7841
• 💔 Build #4556 failed 8ecc714

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.