[Maps] remove ecommerce map saved object from home plugin #116295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
commented
Oct 26, 2021
| @@ -138,55 +138,26 @@ export const getSavedObjects = (): SavedObject[] => [ | |||
| version: 'WzIzLDFd', | |||
| }, | |||
| { | |||
| id: '9c6f83f0-bb4d-11e8-9c84-77068524bcab', | |||
| type: 'visualization', | |||
There was a problem hiding this comment.
Replaced map saved object with vega visualization. Vega visualization gets replaced in dashboard when maps plugin loads
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
|
merging, having ecommerce maps saved object in two places is blocking #116179 |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116263
#107746 put a copy of ecommerce map saved object in the home plugin. The PR did not remove the commerce map saved object from the map plugin. This resulted in #116263.
This PR removes the ecommerce map saved object from the home plugin and keeps the one in the maps plugin. The reason being is that the map saved objects are easier to maintain in the maps plugin. Also, consistency is important in a project as large as Kibana and the logs and flights map saved objects are in the maps plugin. Keeping all map saved objects in the maps plugin for consistency has value.