[Sample Data] Add new Lens vis from eCommerce dashboard to the Vis Library #107746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also removed old replace patch from the maps that changed the Vega vis with the current Maps one: |
|
Tagged the same people for review that reviewed the previous change. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
mshustov
approved these changes
Aug 10, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 10, 2021
…brary (elastic#107746) * Add ecommerce dashboard lens vis to library * layout and existing translations * remove old replace from maps * remove unused translation string Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 10, 2021
…brary (#107746) (#108025) * Add ecommerce dashboard lens vis to library * layout and existing translations * remove old replace from maps * remove unused translation string Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marius Dragomir <marius-dr@users.noreply.github.com>
This was referenced Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to: #106039
With the current implementation, the newly added Lens vis are not in the Visualization Library and are stored in the
panelsJSONof the Dashboard. This makes a report URL for this dashboard to be ~28000 chars instead of the normal ~2000. No changes were done to the visualizations other than adding them to the library, so we can keep the old screenshots.