Timelion App removal #110255

VladLasitsa · 2021-08-26T14:53:42Z

Closes: #100987, Closes #71624, Closes #14624, Closes #10532

Summary

What have been done:

Removed timelion plugin
Removed some field from configSchema in vis_type_timelion which related only to timelion app
Removed advanced settings which related only to timelion app
Removed timelion-sheet saved objects from json's which we use for functional tests
Rewrote functional tests related to expression typeahead so that we can test timelion vis
Removed timelion privilage because it using only for timelion app
Removed everthing which related to timelion app from API and different docs

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

VladLasitsa · 2021-08-27T16:33:48Z

@elasticmachine merge upstream

VladLasitsa · 2021-08-30T07:29:35Z

@elasticmachine merge upstream

VladLasitsa · 2021-08-30T09:57:20Z

@elasticmachine merge upstream

alexwizp · 2021-08-30T15:03:57Z

src/core/public/doc_links/doc_links_service.ts
Should this be removed?

alexwizp · 2021-08-30T15:10:26Z

src/plugins/vis_type_timelion/server/ui_settings.ts

@stratoula This message says that it should be removed in version 8.0. I think it's an issue cause if I'm not wrong we planned to do it in 8.1/2?

stratoula · 2021-08-30T15:13:36Z

@alexwizp yes you are right. Can we change it in another PR?

alexwizp · 2021-08-30T15:23:40Z

src/plugins/index_pattern_editor/public/components/rollup_beta_warning/rollup_beta_warning.tsx
Should we update the following message?

alexwizp · 2021-08-30T15:29:55Z

x-pack/test/functional/es_archives/action_task_params/mappings.json
remove plz "timelion-sheet"

alexwizp · 2021-08-30T15:33:32Z

src/dev/code_coverage/docs/teams_scripted_field.painless
Please check that file

VladLasitsa · 2021-08-31T14:40:41Z

@elasticmachine merge upstream

kibanamachine · 2021-08-31T14:40:43Z

merge conflict between base and head

VladLasitsa · 2021-09-01T07:58:28Z

@elasticmachine merge upstream

VladLasitsa · 2021-09-01T08:12:47Z

src/dev/code_coverage/docs/teams_scripted_field.painless
Please check that file

We should left here timelion because here it as I understand related to vis_type_timelion too.

estermv

Stack Monitoring changes LGTM

mshustov

Ok for the Core changes

stratoula · 2021-09-07T13:48:16Z

@elasticmachine merge upstream

stratoula

Vis editors team code changes LGTM!

Although I had timelion-sheets, kibana didn't fail. I don't see the removed SO type to the SO management page but I can retrieve my timelion expression by the .kibana index.
The whitelisted timelion setting has been removed in cloud https://github.com/elastic/cloud/pull/88014
We are not going to update the docs with a section on how to retrieve your SOs from .kibana index. I will create a known-issue instead.

Very well done @VladLasitsa 👏 This PR feels good :)

LeeDr · 2021-09-08T13:31:11Z

2 questions:

I didn't see any mention here of Canvas. I'm assuming Timelion expressions are still valid in Canvas? Did anybody test to make sure it still works there?
If this is a breaking change why do we have a v7.16.0 label? We would usually only make breaking changes in a major release.

tylersmalley

🎉

watson

Went over all the import statements to see if any of the packages used by timelion was no longer needed after timelion had been removed

watson · 2021-09-08T14:16:28Z

src/plugins/timelion/public/application.ts

-import 'angular-sanitize';
-// required for ngRoute
-import 'angular-route';
-import 'angular-sortable-view';


As far as I can see, this package isn't used anywhere else in Kibana and can be removed from the package.json file

@watson 'angular-sanitize' and 'angular-route' are using in x-pack\plugins\monitoring\public\angular\app_modules.ts. We cannot remove them for now. I can remove only 'angular-sortable-view'.

Sorry, yean I meant just angular-sortable-view. I guess the diff above just shows a bit more than what I'm commenting on 😅

Okay, I've removed angular-sortable-view

tsullivan

Reporting test archive changes LGTM

stratoula · 2021-09-09T06:17:53Z

2 questions:

I didn't see any mention here of Canvas. I'm assuming Timelion expressions are still valid in Canvas? Did anybody test to make sure it still works there?

If this is a breaking change why do we have a v7.16.0 label? We would usually only make breaking changes in a major release.

@LeeDr we don't remove timelion in general. Timelion viz and expressions will work as expected, Only the timelion app is been removed!
The reason we decided to do it in 7.16 is due to its angular usage. But we took all the necessary steps to ensure that we are in sync with the #make-it-minor initiative. We hid the app from the app switcher on v7.0.0 Timelion/hide timelion #30131, we added a deprecation warning both in UI and server-side log output (when the app is enabled) on v7.10.0 Add Timelion deprecation warning to server log #75541 Timelion app deprecation warning #74660 and we also had documentation on how to migrate your sheets to dashboards. Moreover, telemetry indicates that a very small portion of users actually use the timelion app. :)

VladLasitsa · 2021-09-09T10:15:45Z

@elasticmachine merge upstream

FrankHassanabad

LGTM,

Looked through the code owners section and saw that it's just against one file of Cypress so we should be good as it's a mapping change. Cypress tests looked to have run so I think we are good here.

stratoula · 2021-09-09T14:16:18Z

@elasticmachine merge upstream

kibanamachine · 2021-09-10T11:49:33Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`timelion`	66	-	-66

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`visTypeTimelion`	21	2	-19

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`timelion`	185.0KB	-	-185.0KB
`visTypeTimelion`	137.7KB	145.9KB	+8.2KB
total			-176.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`visTypeTimelion`	5	2	-3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	408.4KB	408.4KB	-48.0B
`timelion`	9.8KB	-	-9.8KB
`visTypeTimelion`	25.5KB	19.4KB	-6.1KB
total			-16.0KB

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
`timelion-sheet`	13	-	-13

Unknown metric groups

API count

id	before	after	diff
`visTypeTimelion`	22	2	-20

async chunk count

id	before	after	diff
`timelion`	1	-	-1

References to deprecated APIs

id	before	after	diff
`timelion`	6	-	-6

History

💚 Build #152235 succeeded 738d6d4
💔 Build #152149 failed d0bd9c6
💔 Build #152143 failed 8a26820
💚 Build #151496 succeeded 0e1edf5
💔 Build #151320 failed 1fb400f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

* Remove timelion app and stuff which related to it * Fix CI * Fix lint * Fix tests * Fix tests * Fis tests * Fix some comments * Clean up * fix CI * fix some comments * Fix deprecation examples * Return `enabled` property in config for timelion vis * Remove unused angular lib Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

* Timelion App removal (#110255) * Remove timelion app and stuff which related to it * Fix CI * Fix lint * Fix tests * Fix tests * Fis tests * Fix some comments * Clean up * fix CI * fix some comments * Fix deprecation examples * Return `enabled` property in config for timelion vis * Remove unused angular lib Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> * Fix CI Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

VladLasitsa added 6 commits August 26, 2021 17:43

Remove timelion app and stuff which related to it

0f494e0

Fix CI

41dad17

Fix lint

3d7b0de

Fix tests

1ce2a7d

Fix tests

0e30f0f

Fis tests

862eae2

Merge branch 'master' into timelion_app_removal

ce99bae

Merge branch 'master' into timelion_app_removal

b2c3762

Merge branch 'master' into timelion_app_removal

664e77d

elastic deleted a comment from alexwizp Aug 30, 2021

Fix some comments

688e82c

Clean up

9a0dfd9

Merge remote-tracking branch 'upstream/master' into timelion_app_removal

b07b4f6

Merge branch 'master' into timelion_app_removal

d9915af

fix CI

b9c443f

elastic deleted a comment from kibanamachine Sep 1, 2021

VladLasitsa requested a review from alexwizp September 1, 2021 12:56

estermv approved these changes Sep 6, 2021

View reviewed changes

Return enabled property in config for timelion vis

1fb400f

stratoula requested a review from timductive September 6, 2021 15:44

mshustov approved these changes Sep 7, 2021

View reviewed changes

Merge branch 'master' into timelion_app_removal

0e1edf5

stratoula approved these changes Sep 8, 2021

View reviewed changes

vadimkibana approved these changes Sep 8, 2021

View reviewed changes

tylersmalley approved these changes Sep 8, 2021

View reviewed changes

watson reviewed Sep 8, 2021

View reviewed changes

tsullivan approved these changes Sep 8, 2021

View reviewed changes

VladLasitsa added 2 commits September 9, 2021 12:40

Merge remote-tracking branch 'upstream/master' into timelion_app_removal

b9cc0fa

Remove unused angular lib

8a26820

Merge branch 'master' into timelion_app_removal

d0bd9c6

FrankHassanabad approved these changes Sep 9, 2021

View reviewed changes

kibanamachine and others added 2 commits September 9, 2021 10:16

Merge branch 'master' into timelion_app_removal

738d6d4

Merge remote-tracking branch 'upstream/master' into timelion_app_removal

db8b6e7

VladLasitsa merged commit 70090e3 into elastic:master Sep 10, 2021

VladLasitsa mentioned this pull request Sep 10, 2021

[7.x] Timelion App removal (#110255) #111851

Merged

alexwizp mentioned this pull request Feb 10, 2022

[Timelion] Remove unused /api/timelion/validate/es route #125231

Merged

Mayons mentioned this pull request Apr 20, 2022

Support Elastic Stack 7.16.X and 7.17.X all minor versions wazuh/wazuh-dashboard-plugins#4054

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Timelion App removal #110255

Timelion App removal #110255

VladLasitsa commented Aug 26, 2021 •

edited by timroes

Loading

VladLasitsa commented Aug 27, 2021

VladLasitsa commented Aug 30, 2021

VladLasitsa commented Aug 30, 2021

alexwizp commented Aug 30, 2021 •

edited by VladLasitsa

Loading

alexwizp commented Aug 30, 2021 •

edited

Loading

stratoula commented Aug 30, 2021

alexwizp commented Aug 30, 2021

alexwizp commented Aug 30, 2021 •

edited by VladLasitsa

Loading

alexwizp commented Aug 30, 2021

VladLasitsa commented Aug 31, 2021

kibanamachine commented Aug 31, 2021

VladLasitsa commented Sep 1, 2021

VladLasitsa commented Sep 1, 2021

estermv left a comment

mshustov left a comment

stratoula commented Sep 7, 2021

stratoula left a comment

LeeDr commented Sep 8, 2021 •

edited

Loading

tylersmalley left a comment

watson left a comment

watson Sep 8, 2021

VladLasitsa Sep 9, 2021

watson Sep 9, 2021

VladLasitsa Sep 9, 2021

tsullivan left a comment

stratoula commented Sep 9, 2021

VladLasitsa commented Sep 9, 2021

FrankHassanabad left a comment

stratoula commented Sep 9, 2021

kibanamachine commented Sep 10, 2021

API count

async chunk count

References to deprecated APIs

Timelion App removal #110255

Timelion App removal #110255

Conversation

VladLasitsa commented Aug 26, 2021 • edited by timroes Loading

Summary

Checklist

VladLasitsa commented Aug 27, 2021

VladLasitsa commented Aug 30, 2021

VladLasitsa commented Aug 30, 2021

alexwizp commented Aug 30, 2021 • edited by VladLasitsa Loading

alexwizp commented Aug 30, 2021 • edited Loading

stratoula commented Aug 30, 2021

alexwizp commented Aug 30, 2021

alexwizp commented Aug 30, 2021 • edited by VladLasitsa Loading

alexwizp commented Aug 30, 2021

VladLasitsa commented Aug 31, 2021

kibanamachine commented Aug 31, 2021

VladLasitsa commented Sep 1, 2021

VladLasitsa commented Sep 1, 2021

estermv left a comment

Choose a reason for hiding this comment

mshustov left a comment

Choose a reason for hiding this comment

stratoula commented Sep 7, 2021

stratoula left a comment

Choose a reason for hiding this comment

LeeDr commented Sep 8, 2021 • edited Loading

tylersmalley left a comment

Choose a reason for hiding this comment

watson left a comment

Choose a reason for hiding this comment

watson Sep 8, 2021

Choose a reason for hiding this comment

VladLasitsa Sep 9, 2021

Choose a reason for hiding this comment

watson Sep 9, 2021

Choose a reason for hiding this comment

VladLasitsa Sep 9, 2021

Choose a reason for hiding this comment

tsullivan left a comment

Choose a reason for hiding this comment

stratoula commented Sep 9, 2021

VladLasitsa commented Sep 9, 2021

FrankHassanabad left a comment

Choose a reason for hiding this comment

stratoula commented Sep 9, 2021

kibanamachine commented Sep 10, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

Saved Objects .kibana field count

API count

async chunk count

References to deprecated APIs

History

VladLasitsa commented Aug 26, 2021 •

edited by timroes

Loading

alexwizp commented Aug 30, 2021 •

edited by VladLasitsa

Loading

alexwizp commented Aug 30, 2021 •

edited

Loading

alexwizp commented Aug 30, 2021 •

edited by VladLasitsa

Loading

LeeDr commented Sep 8, 2021 •

edited

Loading