Add Timelion deprecation warning to server log #75541
Conversation
| ({ total }) => | ||
| total && | ||
| logger.warn( | ||
| 'Timelion plugin was deprecated since 7.0, the Timelion app will be removed in 8.0.' |
There was a problem hiding this comment.
Let's be more verbose here, that they still have timelion worksheets saved and maybe directly output the link to the docuemntation.
I'd suggest the following (cc @gchaps and @KOTungseth for final message):
The timelion application was deprecated since 7.0 and will be removed in 8.0. You still have saved timelion application worksheets, which you need to migrate manually to dashboards if you want to keep them after 8.0. See https://www.elastic.co/guide/en/kibana/master/timelion.html#timelion-deprecation for more details.
It seems that the doc_links service is not available on the serverside to generate links. That would mean we need to hardcode that link here, unless Platform team has still plans to expose it also server side (cc @joshdover could you give some details on this?)
There was a problem hiding this comment.
The warning we have on the app could be used here too as was suggested by @gchaps
Deprecated since 7.0, the Timelion app will be removed in 8.0. To continue using your Timelion worksheets, migrate them to a dashboard. See https://www.elastic.co/guide/en/kibana/master/timelion.html#timelion-deprecation
There was a problem hiding this comment.
@stratoula @timroes it was initially like on app. Then I updated it as Tim suggested.
Does it mean that I should return it back? Actually I like 2 options. Probably we can keep it as it
There was a problem hiding this comment.
No don't return it back! Let's wait for @gchaps and @KOTungseth for the final message
There was a problem hiding this comment.
I agree with @stratoula that the text in the message and docs should be the same. If this text suits your needs, then I would go with it:
Deprecated since 7.0, the Timelion app will be removed in 8.0. To continue using your Timelion worksheets, migrate them to a dashboard. See https://www.elastic.co/guide/en/kibana/master/timelion.html#timelion-deprecation.
|
Tested it with and without sheets, works as it should 🎉 |
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
| root = kbnTestServer.createRoot(); | ||
| root = kbnTestServer.createRoot({ plugins: { initialize: false } }); |
There was a problem hiding this comment.
Just to understand, why did you have to add the { plugins: { initialize: false } } option to these core integration tests? Is that just test perf optimization?
There was a problem hiding this comment.
@joshdover helped me with that to fix these type of issues: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/69612/
There was a problem hiding this comment.
Oh right, that is adding an ES call during start so it would cause ES connection errors. Thanks.
* Add Timelion deprecation warning to the migration assistant Closes: elastic#63014 * fix PR comments * update message * fix integration tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Add Timelion deprecation warning to the migration assistant Closes: #63014 * fix PR comments * update message * fix integration tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Closes: #63014
Summary
This PR closes #63014 (comment)
Deprecation message was added:
Checklist
Delete any items that are not applicable to this PR.
For maintainers