Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timelion] Remove unused /api/timelion/validate/es route #125231

Merged
merged 1 commit into from
Feb 10, 2022
Merged

[Timelion] Remove unused /api/timelion/validate/es route #125231

merged 1 commit into from
Feb 10, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Feb 10, 2022 •
edited
Loading

Summary

After merging #110255 we don't use /api/timelion/validate/es route any more. It can be removed

@alexwizp alexwizp requested a review from VladLasitsa February 10, 2022 13:12
@alexwizp alexwizp self-assigned this Feb 10, 2022
@alexwizp alexwizp added Feature:Timelion Timelion app and visualization v8.2.0 release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 10, 2022
@alexwizp alexwizp marked this pull request as ready for review February 10, 2022 13:13
@alexwizp alexwizp requested a review from a team as a code owner February 10, 2022 13:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

flash1293
flash1293 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified it's not used anywhere anymore

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit 8ee9765 into elastic:main Feb 10, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125231 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 14, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125231 or prevent reminders by adding the backport:skip label.

@stratoula stratoula added the backport:skip This commit does not require backporting label Feb 15, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

Assignees

@alexwizp alexwizp

Labels
backport:skip This commit does not require backporting Feature:Timelion Timelion app and visualization release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexwizp @elasticmachine @kibana-ci @kibanamachine @flash1293 @stratoula