[Canvas] Expression repeat image #104255
Merged
[Canvas] Expression repeat image #104255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
530f36a to
dd5f20f
Compare
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
# Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
jbudz
approved these changes
Jul 22, 2021
|
@jbudz, thank you for the review ) |
crob611
approved these changes
Jul 22, 2021
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import { ExpressionMetricPlugin } from './plugin'; |
There was a problem hiding this comment.
Should be ExpressionRepeatImagePlugin. Probably just a copy/paste remnant.
| implements | ||
| Plugin<ExpressionMetricPluginSetup, ExpressionMetricPluginStart, SetupDeps, StartDeps> { | ||
| public setup(core: CoreSetup, { expressions }: SetupDeps): ExpressionMetricPluginSetup { | ||
| expressions.registerRenderer(repeatImageRenderer); |
There was a problem hiding this comment.
Can you also register the function here so that it is available both client and server side.
|
@crob611, thanks for your review) |
# Conflicts: # x-pack/plugins/translations/translations/zh-CN.json
💔 Backport failed
To backport manually run: |
Kuznietsov
added a commit
to Kuznietsov/kibana
that referenced
this pull request
Jul 23, 2021
* Repeat Image plugin added. # Conflicts: # packages/kbn-optimizer/limits.yml # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
Kuznietsov
added a commit
that referenced
this pull request
Jul 23, 2021
* [Canvas] Expression repeat image (#104255) * Repeat Image plugin added. # Conflicts: # packages/kbn-optimizer/limits.yml # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json * Removed not defined plugin `userSetup`.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
API count missing comments
async chunk count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @Kunzetsov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes a part of #101377.
Fixes: #97087
At this PR
repeatImageexpression is extracted from the canvas plugin and set up as a separate plugin.List of required changes to be done:
repeatImageexpression from canvas to a separate plugin.tsandReact.Storybookfor therepeatImageexpression renderer.canvaspluginTesting Notes
This moves the repeat_image expression function to a standalone plugin and refactors the code. To test, just test that the repeat_image expression in canvas continues to work as expected.