Made fixes, based on nits.

elastic · Jul 22, 2021 · 2cc4a85 · 2cc4a85
1 parent bc6486f
commit 2cc4a85
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 9 deletions.
diff --git a/src/plugins/expression_repeat_image/public/index.ts b/src/plugins/expression_repeat_image/public/index.ts
@@ -6,12 +6,12 @@
  * Side Public License, v 1.
  */
 
-import { ExpressionMetricPlugin } from './plugin';
+import { ExpressionRepeatImagePlugin } from './plugin';
 
-export type { ExpressionMetricPluginSetup, ExpressionMetricPluginStart } from './plugin';
+export type { ExpressionRepeatImagePluginSetup, ExpressionRepeatImagePluginStart } from './plugin';
 
 export function plugin() {
-  return new ExpressionMetricPlugin();
+  return new ExpressionRepeatImagePlugin();
 }
 
 export * from './expression_renderers';
diff --git a/src/plugins/expression_repeat_image/public/plugin.ts b/src/plugins/expression_repeat_image/public/plugin.ts
@@ -8,6 +8,7 @@
 
 import { CoreSetup, CoreStart, Plugin } from '../../../core/public';
 import { ExpressionsStart, ExpressionsSetup } from '../../expressions/public';
+import { repeatImageFunction } from '../common/expression_functions';
 import { repeatImageRenderer } from './expression_renderers';
 
 interface SetupDeps {
@@ -18,17 +19,23 @@ interface StartDeps {
   expression: ExpressionsStart;
 }
 
-export type ExpressionMetricPluginSetup = void;
-export type ExpressionMetricPluginStart = void;
+export type ExpressionRepeatImagePluginSetup = void;
+export type ExpressionRepeatImagePluginStart = void;
 
-export class ExpressionMetricPlugin
+export class ExpressionRepeatImagePlugin
   implements
-    Plugin<ExpressionMetricPluginSetup, ExpressionMetricPluginStart, SetupDeps, StartDeps> {
-  public setup(core: CoreSetup, { expressions }: SetupDeps): ExpressionMetricPluginSetup {
+    Plugin<
+      ExpressionRepeatImagePluginSetup,
+      ExpressionRepeatImagePluginStart,
+      SetupDeps,
+      StartDeps
+    > {
+  public setup(core: CoreSetup, { expressions }: SetupDeps): ExpressionRepeatImagePluginSetup {
+    expressions.registerFunction(repeatImageFunction);
     expressions.registerRenderer(repeatImageRenderer);
   }
 
-  public start(core: CoreStart): ExpressionMetricPluginStart {}
+  public start(core: CoreStart): ExpressionRepeatImagePluginStart {}
 
   public stop() {}
 }