[Canvas] Repeat image bug with image height fixed. #121497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
|
@crob611 or anybody from @elastic/kibana-presentation, could you, please, review current PR) Thanks for your efforts) |
|
@elasticmachine merge upstream |
crob611
approved these changes
Dec 22, 2021
| @@ -49,7 +49,8 @@ function createImageJSX(img: HTMLImageElement | null) { | |||
| if (!img) { | |||
| return null; | |||
| } | |||
| const params = img.width > img.height ? { heigth: img.height } : { width: img.width }; | |||
| // console.log(img.height, img.width); | |||
There was a problem hiding this comment.
please remove this commented out console.log
There was a problem hiding this comment.
Sure, sorry for that. 👍
…bana into repeat-image-expression-fix
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @Kunzetsov |
💔 Backport failed
To backport manually run: |
Kuznietsov
added a commit
to Kuznietsov/kibana
that referenced
this pull request
Dec 22, 2021
* Fixed typo and increased performance. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/expression_repeat_image/public/components/repeat_image_component.tsx
Kuznietsov
added a commit
to Kuznietsov/kibana
that referenced
this pull request
Dec 22, 2021
* Fixed typo and increased performance. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/expression_repeat_image/public/components/repeat_image_component.tsx
Kuznietsov
added a commit
that referenced
this pull request
Dec 22, 2021
Kuznietsov
added a commit
that referenced
this pull request
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #121496.
Fixes bug, introduced at this PR.
And increased the performance of images rendering.