Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: convert EuiTable unit tests using enzyme render to RTL #6969

Merged
merged 1 commit into from
Jul 20, 2023
Merged

test: convert EuiTable unit tests using enzyme render to RTL #6969

merged 1 commit into from
Jul 20, 2023

Conversation

tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented Jul 19, 2023 •
edited
Loading

Summary

This PR converts EuiTable unit tests using Enzyme's render() function to RTL render() counterpart to reduce our tech debt.

QA

  • Make sure all unit tests are passing
  • Verify the updated snapshots don't contain any unexpected changes

General checklist

@tkajtoch tkajtoch added testing Issues or PRs that only affect tests - will not need changelog entries skip-changelog tech debt labels Jul 19, 2023
@tkajtoch tkajtoch requested a review from a team July 19, 2023 22:23
@tkajtoch tkajtoch self-assigned this Jul 19, 2023
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6969/

@tkajtoch tkajtoch mentioned this pull request Jul 20, 2023
Closed
@tkajtoch
Copy link
Member Author

jenkins test this please

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6969/

@tkajtoch tkajtoch mentioned this pull request Jul 20, 2023
Closed
cee-chen
cee-chen approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good/straightforward - looks like CI won't pass until main (with the DOM validation skip) is merged/rebased in though

@tkajtoch tkajtoch force-pushed the test/convert-enzyme-render-to-rtl-table branch from 988b851 to 04a9553 Compare July 20, 2023 18:45
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6969/

@tkajtoch tkajtoch merged commit 47a02dd into elastic:main Jul 20, 2023
@tkajtoch tkajtoch deleted the test/convert-enzyme-render-to-rtl-table branch July 20, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees

@tkajtoch tkajtoch

Labels
skip-changelog tech debt testing Issues or PRs that only affect tests - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkajtoch @kibanamachine @cee-chen