Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: convert EuiTable unit tests using enzyme render to RTL #6969

Merged
merged 1 commit into from
Jul 20, 2023
Merged

test: convert EuiTable unit tests using enzyme render to RTL #6969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/table/__snapshots__/table.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ exports[`renders EuiTable 1`] = `
>
<span
class="euiTableCellContent__text"
title="Hi Title"
>
Hi Title
</span>
Expand All @@ -34,6 +35,7 @@ exports[`renders EuiTable 1`] = `
>
<span
class="euiTableCellContent__text"
title="Bye Title"
>
Bye Title
</span>
Expand Down
11 changes: 6 additions & 5 deletions src/components/table/__snapshots__/table_footer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`EuiTableFooter is rendered 1`] = `
Array [
<div>
<tfoot
aria-label="aria-label"
class="testClass1 testClass2 emotion-euiTestCss"
data-test-subj="test subject string"
>
<tr />
</tfoot>,
"children",
]
<tr>
children
</tr>
</tfoot>
</div>
`;
8 changes: 4 additions & 4 deletions src/components/table/__snapshots__/table_footer_cell.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ exports[`EuiTableFooterCell is rendered 1`] = `
exports[`EuiTableFooterCell width and style accepts style attribute 1`] = `
<td
class="euiTableFooterCell"
style="width:20%"
style="width: 20%;"
>
<div
class="euiTableCellContent"
Expand All @@ -80,7 +80,7 @@ exports[`EuiTableFooterCell width and style accepts style attribute 1`] = `
exports[`EuiTableFooterCell width and style accepts width attribute 1`] = `
<td
class="euiTableFooterCell"
style="width:10%"
style="width: 10%;"
>
<div
class="euiTableCellContent"
Expand All @@ -97,7 +97,7 @@ exports[`EuiTableFooterCell width and style accepts width attribute 1`] = `
exports[`EuiTableFooterCell width and style accepts width attribute as number 1`] = `
<td
class="euiTableFooterCell"
style="width:100px"
style="width: 100px;"
>
<div
class="euiTableCellContent"
Expand All @@ -114,7 +114,7 @@ exports[`EuiTableFooterCell width and style accepts width attribute as number 1`
exports[`EuiTableFooterCell width and style resolves style and width attribute 1`] = `
<td
class="euiTableFooterCell"
style="width:10%"
style="width: 10%;"
>
<div
class="euiTableCellContent"
Expand Down
17 changes: 13 additions & 4 deletions src/components/table/__snapshots__/table_header_cell.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ exports[`renders EuiTableHeaderCell 1`] = `
>
<span
class="euiTableCellContent__text"
title="children"
>
children
</span>
Expand Down Expand Up @@ -95,6 +96,7 @@ exports[`sorting does not render a button with readOnly 1`] = `
>
<span
class="euiTableCellContent__text"
title="Test"
>
Test
</span>
Expand All @@ -119,6 +121,7 @@ exports[`sorting is rendered with isSortAscending 1`] = `
>
<span
class="euiTableCellContent__text"
title="Test"
>
Test
</span>
Expand All @@ -143,6 +146,7 @@ exports[`sorting is rendered with isSorted 1`] = `
>
<span
class="euiTableCellContent__text"
title="Test"
>
Test
</span>
Expand Down Expand Up @@ -172,6 +176,7 @@ exports[`sorting renders a button with onSort 1`] = `
>
<span
class="euiTableCellContent__text"
title="Test"
>
Test
</span>
Expand All @@ -189,13 +194,14 @@ exports[`width and style accepts style attribute 1`] = `
class="euiTableHeaderCell"
role="columnheader"
scope="col"
style="width:20%"
style="width: 20%;"
>
<span
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
title="Test"
>
Test
</span>
Expand All @@ -208,13 +214,14 @@ exports[`width and style accepts width attribute 1`] = `
class="euiTableHeaderCell"
role="columnheader"
scope="col"
style="width:10%"
style="width: 10%;"
>
<span
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
title="Test"
>
Test
</span>
Expand All @@ -227,13 +234,14 @@ exports[`width and style accepts width attribute as number 1`] = `
class="euiTableHeaderCell"
role="columnheader"
scope="col"
style="width:100px"
style="width: 100px;"
>
<span
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
title="Test"
>
Test
</span>
Expand All @@ -246,13 +254,14 @@ exports[`width and style resolves style and width attribute 1`] = `
class="euiTableHeaderCell"
role="columnheader"
scope="col"
style="width:10%"
style="width: 10%;"
>
<span
class="euiTableCellContent"
>
<span
class="euiTableCellContent__text"
title="Test"
>
Test
</span>
Expand Down
8 changes: 4 additions & 4 deletions src/components/table/__snapshots__/table_header_cell_checkbox.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ exports[`EuiTableHeaderCellCheckbox width and style accepts style attribute 1`]
<th
class="euiTableHeaderCellCheckbox"
scope="col"
style="width:20%"
style="width: 20%;"
>
<div
class="euiTableCellContent"
Expand All @@ -31,7 +31,7 @@ exports[`EuiTableHeaderCellCheckbox width and style accepts width attribute 1`]
<th
class="euiTableHeaderCellCheckbox"
scope="col"
style="width:10%"
style="width: 10%;"
>
<div
class="euiTableCellContent"
Expand All @@ -45,7 +45,7 @@ exports[`EuiTableHeaderCellCheckbox width and style accepts width attribute as n
<th
class="euiTableHeaderCellCheckbox"
scope="col"
style="width:100px"
style="width: 100px;"
>
<div
class="euiTableCellContent"
Expand All @@ -59,7 +59,7 @@ exports[`EuiTableHeaderCellCheckbox width and style resolves style and width att
<th
class="euiTableHeaderCellCheckbox"
scope="col"
style="width:10%"
style="width: 10%;"
>
<div
class="euiTableCellContent"
Expand Down
8 changes: 4 additions & 4 deletions src/components/table/__snapshots__/table_row_cell.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ exports[`valign renders top when specified 1`] = `
exports[`width and style accepts style attribute 1`] = `
<td
class="euiTableRowCell euiTableRowCell--middle"
style="width:20%"
style="width: 20%;"
>
<div
class="euiTableCellContent"
Expand All @@ -188,7 +188,7 @@ exports[`width and style accepts style attribute 1`] = `
exports[`width and style accepts width attribute 1`] = `
<td
class="euiTableRowCell euiTableRowCell--middle"
style="width:10%"
style="width: 10%;"
>
<div
class="euiTableCellContent"
Expand All @@ -205,7 +205,7 @@ exports[`width and style accepts width attribute 1`] = `
exports[`width and style accepts width attribute as number 1`] = `
<td
class="euiTableRowCell euiTableRowCell--middle"
style="width:100px"
style="width: 100px;"
>
<div
class="euiTableCellContent"
Expand All @@ -222,7 +222,7 @@ exports[`width and style accepts width attribute as number 1`] = `
exports[`width and style resolves style and width attribute 1`] = `
<td
class="euiTableRowCell euiTableRowCell--middle"
style="width:10%"
style="width: 10%;"
>
<div
class="euiTableCellContent"
Expand Down
6 changes: 3 additions & 3 deletions src/components/table/mobile/table_header_mobile.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
*/

import React from 'react';
import { render } from 'enzyme';
import { requiredProps } from '../../../test';
import { render } from '../../../test/rtl';

import { EuiTableHeaderMobile } from './table_header_mobile';

describe('EuiTableHeaderMobile', () => {
test('is rendered', () => {
const component = render(<EuiTableHeaderMobile {...requiredProps} />);
const { container } = render(<EuiTableHeaderMobile {...requiredProps} />);

expect(component).toMatchSnapshot();
expect(container.firstChild).toMatchSnapshot();
});
});
6 changes: 3 additions & 3 deletions src/components/table/mobile/table_sort_mobile.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
*/

import React from 'react';
import { render } from 'enzyme';
import { requiredProps } from '../../../test';
import { render } from '../../../test/rtl';

import { EuiTableSortMobile } from './table_sort_mobile';

describe('EuiTableSortMobile', () => {
test('is rendered', () => {
const component = render(<EuiTableSortMobile {...requiredProps} />);
const { container } = render(<EuiTableSortMobile {...requiredProps} />);

expect(component).toMatchSnapshot();
expect(container.firstChild).toMatchSnapshot();
});
});
6 changes: 3 additions & 3 deletions src/components/table/mobile/table_sort_mobile_item.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
*/

import React from 'react';
import { render } from 'enzyme';
import { requiredProps } from '../../../test';
import { render } from '../../../test/rtl';

import { EuiTableSortMobileItem } from './table_sort_mobile_item';

describe('EuiTableSortMobileItem', () => {
test('is rendered', () => {
const component = render(<EuiTableSortMobileItem {...requiredProps} />);
const { container } = render(<EuiTableSortMobileItem {...requiredProps} />);

expect(component).toMatchSnapshot();
expect(container.firstChild).toMatchSnapshot();
});
});
6 changes: 3 additions & 3 deletions src/components/table/table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
*/

import React from 'react';
import { render } from 'enzyme';
import { requiredProps } from '../../test/required_props';
import { render } from '../../test/rtl';

import { EuiTable } from './table';
import { EuiTableRow } from './table_row';
Expand All @@ -18,7 +18,7 @@ import { EuiTableHeader } from './table_header';
import { EuiTableHeaderCell } from './table_header_cell';

test('renders EuiTable', () => {
const component = (
const { container } = render(
<EuiTable {...requiredProps}>
<EuiTableHeader>
<EuiTableHeaderCell>Hi Title</EuiTableHeaderCell>
Expand All @@ -34,5 +34,5 @@ test('renders EuiTable', () => {
</EuiTableBody>
</EuiTable>
);
expect(render(component)).toMatchSnapshot();
expect(container.firstChild).toMatchSnapshot();
});
6 changes: 3 additions & 3 deletions src/components/table/table_footer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@
*/

import React from 'react';
import { render } from 'enzyme';
import { requiredProps } from '../../test/required_props';
import { render } from '../../test/rtl';

import { EuiTableFooter } from './table_footer';

describe('EuiTableFooter', () => {
test('is rendered', () => {
const component = render(
const { container } = render(
<EuiTableFooter {...requiredProps}>children</EuiTableFooter>
);

expect(component).toMatchSnapshot();
expect(container).toMatchSnapshot();
});
});
Loading