Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOM nesting issues reported by validateDOMNesting #6979

Closed
tkajtoch opened this issue Jul 20, 2023 · 3 comments · Fixed by #7508
Closed

Fix DOM nesting issues reported by validateDOMNesting #6979

tkajtoch opened this issue Jul 20, 2023 · 3 comments · Fixed by #7508

Comments

@tkajtoch
Copy link
Member

tkajtoch commented Jul 20, 2023

Running React 18 and RTL tests reported a small amount of DOM nesting errors that should be fixed.

@tkajtoch to list all errors when RTL test conversion PRs are merged (#6968, #6969, #6970, #6971, #6972, #6973, #6974, #6975, #6976, #6977).

@JasonStoltz
Copy link
Member

JasonStoltz commented Sep 11, 2023

Per Tomasz, this may be affecting SSR code as well. EUIText is the primary component this is affecting.

@JasonStoltz
Copy link
Member

@tkajtoch Can you put a list of non-production affecting components to fix in the short-term?

@breehall
Copy link
Contributor

Running list of component throwing validateDOMNesting warnings:

  • EuiTableHeaderCellCheckbox
  • EuiRowCell
  • EuiHeaderCell
  • EuiTableRowCellCheckbox
  • EuiTableFooter
  • EuiTableRow
  • EuiTableHeader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants