Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: convert EuiForm unit tests using enzyme render to RTL #6970

Merged
merged 1 commit into from
Jul 20, 2023
Merged

test: convert EuiForm unit tests using enzyme render to RTL #6970

merged 1 commit into from
Jul 20, 2023

Conversation

tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented Jul 19, 2023 •
edited
Loading

Summary

This PR converts EuiForm unit tests using Enzyme's render() function to RTL render() counterpart to reduce our tech debt.

QA

  • Make sure all unit tests are passing
  • Verify the updated snapshots don't contain any unexpected changes

General checklist

@tkajtoch tkajtoch added testing Issues or PRs that only affect tests - will not need changelog entries skip-changelog tech debt labels Jul 19, 2023
@tkajtoch tkajtoch requested a review from a team July 19, 2023 22:26
@tkajtoch tkajtoch self-assigned this Jul 19, 2023
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6970/

This was referenced Jul 20, 2023
Closed
Closed
1Copenut
1Copenut approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Tests passed on my local after $ yarn && yarn test-unit. Code changes to refactor throw Error to positive assertions were easy to reason about.

@tkajtoch tkajtoch merged commit d3472a0 into elastic:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1Copenut 1Copenut 1Copenut approved these changes

Assignees

@tkajtoch tkajtoch

Labels
skip-changelog tech debt testing Issues or PRs that only affect tests - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkajtoch @kibanamachine @1Copenut