Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17](backport #6805) [ci] disable kubernetes_secrets unit-test on windows that relies on timing #6815

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 11, 2025

What does this PR do?

For the same reason, as the one captured here, this PR disables timing-based unit-test for kubernetes_secrets provider on Windows platform

Why is it important?

Because we need our CI to be green and timing-based unit-tests on windows are proven to be flaky

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

N/A

How to test this PR locally

N/A

Related issues

N/A


This is an automatic backport of pull request #6805 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner February 11, 2025 15:39
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Feb 11, 2025
@mergify mergify bot requested review from michalpristas and blakerouse and removed request for a team February 11, 2025 15:39
Copy link
Contributor Author

mergify bot commented Feb 11, 2025

Cherry-pick of 45e3abf has failed:

On branch mergify/bp/8.17/pr-6805
Your branch is up to date with 'origin/8.17'.

You are currently cherry-picking commit 45e3abf15.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   internal/pkg/composable/providers/kubernetessecrets/kubernetes_secrets_test.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 11, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pkoutsovasilis
Copy link
Contributor

requires this one to be merged first

@pkoutsovasilis pkoutsovasilis force-pushed the mergify/bp/8.17/pr-6805 branch from 20b2184 to d1ed770 Compare February 14, 2025 21:34
@pkoutsovasilis pkoutsovasilis enabled auto-merge (squash) February 14, 2025 21:34
Copy link

@pkoutsovasilis pkoutsovasilis merged commit c7273f9 into 8.17 Feb 14, 2025
14 checks passed
@pkoutsovasilis pkoutsovasilis deleted the mergify/bp/8.17/pr-6805 branch February 14, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants