Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestAddToBucket/errors_>_than_limit_within_timespans,_off_by_one #3290

Open
cmacknz opened this issue Aug 24, 2023 · 2 comments
Open

TestAddToBucket/errors_>_than_limit_within_timespans,_off_by_one #3290

cmacknz opened this issue Aug 24, 2023 · 2 comments
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@cmacknz
Copy link
Member

cmacknz commented Aug 24, 2023

Flaky Test

Stack Trace

=== RUN   TestAddToBucket/errors_>_than_limit_within_timespans,_off_by_one
    command_test.go:41: 2023-08-24 18:01:06.065255 +0000 GMT m=+1.312210301 : add 1 element when there are 2.000000 tokens available
    command_test.go:41: 2023-08-24 18:01:06.1669009 +0000 GMT m=+1.413856201 : add 1 element when there are 2.000000 tokens available
    command_test.go:41: 2023-08-24 18:01:06.1692908 +0000 GMT m=+1.416246101 : add 1 element when there are 1.031865 tokens available
    command_test.go:46: 
        	Error Trace:	C:/Users/jenkins/workspace/_agent_elastic-agent-mbp_PR-3289/src/github.com/elastic/elastic-agent/pkg/component/runtime/command_test.go:46
        	Error:      	Not equal: 
        	            	expected: true
        	            	actual  : false
        	Test:       	TestAddToBucket/errors_>_than_limit_within_timespans,_off_by_one
--- FAIL: TestAddToBucket/errors_>_than_limit_within_timespans,_off_by_one (0.29s)
@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Aug 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@cmacknz
Copy link
Member Author

cmacknz commented Aug 24, 2023

There is nothing Windows specific in these tests, easiest path now is to just skip them completely on Windows. Our Windows CI agents appear to be slower or at least more variable in their timing, there is little value in tuning this test to work specifically on them. We have tried to fix this multiple times already by changing the timing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

2 participants