Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] disable kubernetes_secrets unit-test on windows that relies on timing #6805

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[ci] disable kubernetes_secrets unit-test on windows that relies on timing #6805

merged 1 commit into from
Feb 11, 2025

Conversation

pkoutsovasilis
Copy link
Contributor

What does this PR do?

For the same reason, as the one captured here, this PR disables timing-based unit-test for kubernetes_secrets provider on Windows platform

Why is it important?

Because we need our CI to be green and timing-based unit-tests on windows are proven to be flaky

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

N/A

How to test this PR locally

N/A

Related issues

N/A

@pkoutsovasilis pkoutsovasilis added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Feb 11, 2025
@pkoutsovasilis pkoutsovasilis self-assigned this Feb 11, 2025
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner February 11, 2025 11:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pkoutsovasilis pkoutsovasilis mentioned this pull request Feb 11, 2025
Open
8 tasks
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@pkoutsovasilis pkoutsovasilis merged commit 45e3abf into elastic:main Feb 11, 2025
22 checks passed
mergify bot pushed a commit that referenced this pull request Feb 11, 2025
@pkoutsovasilis @mergify
fix: disable kubernetes_secrets unit-test that relies on timing for w…
b274bf8 
…indows platform (#6805)

(cherry picked from commit 45e3abf)

# Conflicts:
#	internal/pkg/composable/providers/kubernetessecrets/kubernetes_secrets_test.go
mergify bot pushed a commit that referenced this pull request Feb 11, 2025
@pkoutsovasilis @mergify
fix: disable kubernetes_secrets unit-test that relies on timing for w…
280a505 
…indows platform (#6805)

(cherry picked from commit 45e3abf)

# Conflicts:
#	internal/pkg/composable/providers/kubernetessecrets/kubernetes_secrets_test.go
mergify bot pushed a commit that referenced this pull request Feb 11, 2025
@pkoutsovasilis @mergify
fix: disable kubernetes_secrets unit-test that relies on timing for w…
9906c34 
…indows platform (#6805)

(cherry picked from commit 45e3abf)
This was referenced Feb 11, 2025
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Feb 11, 2025
@pkoutsovasilis @mergify
fix: disable kubernetes_secrets unit-test that relies on timing for w…
d942075 
…indows platform (#6805)

(cherry picked from commit 45e3abf)
@mergify mergify bot mentioned this pull request Feb 11, 2025
Merged
8 tasks
pkoutsovasilis added a commit that referenced this pull request Feb 11, 2025
@mergify @pkoutsovasilis
fix: disable kubernetes_secrets unit-test that relies on timing for w…
6690975 
…indows platform (#6805) (#6816)

(cherry picked from commit 45e3abf)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis added a commit that referenced this pull request Feb 12, 2025
@mergify @pkoutsovasilis
fix: disable kubernetes_secrets unit-test that relies on timing for w…
98c3126 
…indows platform (#6805) (#6817)

(cherry picked from commit 45e3abf)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
@pierrehilbert pierrehilbert added the skipped-test This change disables one or multiple tests label Feb 14, 2025
pierrehilbert pushed a commit that referenced this pull request Feb 14, 2025
@mergify @pkoutsovasilis
fix: disable kubernetes_secrets unit-test that relies on timing for w…
aeb7e16 
…indows platform (#6805) (#6814)

(cherry picked from commit 45e3abf)

# Conflicts:
#	internal/pkg/composable/providers/kubernetessecrets/kubernetes_secrets_test.go

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis added a commit that referenced this pull request Feb 14, 2025
@pkoutsovasilis
fix: disable kubernetes_secrets unit-test that relies on timing for w…
d1ed770 
…indows platform (#6805)

(cherry picked from commit 45e3abf)
pkoutsovasilis added a commit that referenced this pull request Feb 14, 2025
@mergify @pkoutsovasilis
fix: disable kubernetes_secrets unit-test that relies on timing for w…
c7273f9 
…indows platform (#6805) (#6815)

(cherry picked from commit 45e3abf)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@pkoutsovasilis pkoutsovasilis

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch bug Something isn't working skip-changelog skipped-test This change disables one or multiple tests Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkoutsovasilis @elasticmachine @swiatekm @pierrehilbert