Update metricbeat full config to have all modules disabled #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5e9e13 to
23193a9
Compare
23193a9 to
7395655
Compare
|
@monicasarbu Rebased |
7395655 to
a20e8f2
Compare
Currently modules in the full config were disabled by commenting it out. Unfortunately we were not very consistent in the commenting style and some were missing the comments which enabled some of the modules. Having the configs commented out also meant they are commented out in the documentation as the same config files are used to generate the docs. Only system module has a short config as it is the one enabled by default. For all the other modules I merged removed the short config as we should come up with one as soon as we need it, means it's in the short config. So the full config files for the modules were removed and merged into the short one. This change in the full config will also simplify copy / paste of config options for adding it to the short config. Only thing that has to be changed is the enabled flag. Experimental log message and note are now added to each new metricset by default.
a20e8f2 to
a425890
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently modules in the full config were disabled by commenting it out. Unfortunately we were not very consistent in the commenting style and some were missing the comments which enabled some of the modules.
Having the configs commented out also meant they are commented out in the documentation as the same config files are used to generate the docs.
Only system module has a short config as it is the one enabled by default. For all the other modules I merged removed the short config as we should come up with one as soon as we need it, means it's in the short config. So the full config files for the modules were removed and merged into the short one.
This change in the full config will also simplify copy / paste of config options for adding it to the short config. Only thing that has to be changed is the enabled flag.
Experimental log message and note are now added to each new metricset by default.