Set short_config option to false by default in Metricbeat #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e12fe72 to
519e242
Compare
So far for each new module the configs were added to the short config by default. But by default we didnt want to have it there. So not every module has to add `short_config: false` to each module, short_config is now set to False by default. This will not have any affect except for new modules. * System module short_config was set to true * Redis short_config entry was removed as an example * Update filebeat modules as all modules are in short_config at the moment * Move config_collector.py to global script directory so all beats can use it
519e242 to
38f9e94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far for each new module the configs were added to the short config by default. But by default we didnt want to have it there. So not every module has to add
short_config: falseto each module, short_config is now set to False by default. This will not have any affect except for new modules.