Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metricbeat full config files #3180

Closed
wants to merge 1 commit into from
Closed

Update metricbeat full config files #3180

wants to merge 1 commit into from

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Dec 13, 2016

There should not be any behavioural change.

@ruflin
Update metricbeat full config files
1d6e302 
* Apply elastic#3179 to config files
* Set short configs which are not enabled to enabled:false

There should not be any behavioural change.
@ruflin ruflin force-pushed the metricbeat-full-config branch from 547ed0a to 1d6e302 Compare December 13, 2016 09:32
@ruflin ruflin mentioned this pull request Dec 13, 2016
Closed
8 tasks
tsg
tsg approved these changes Jan 2, 2017
View reviewed changes
Copy link
Contributor

@tsg tsg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As we're going to start 3 weeks of testing, we should probably merge these before the feature freeze. @ruflin, waiting for your 👍 before merging, as we probably want to merge all related PRs at once.

@ruflin
Copy link
Contributor Author

ruflin commented Jan 2, 2017

@tsg As the libbeat part is still missing and in other PR's there are some open questions, I suggest we keep this for the next minor / major release, so we don't merge it now. This also gives us the opportunity to add more tests. And it will also allow us to merge one PR after the other going step by step.

@monicasarbu monicasarbu added the in progress Pull request is currently in progress. label Jan 10, 2017
@ruflin ruflin removed the review label Jan 20, 2017
@ruflin
Copy link
Contributor Author

ruflin commented Apr 20, 2017

Closing in favor of #4049

@ruflin ruflin closed this Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsg tsg tsg approved these changes

Assignees
No one assigned
Labels
in progress Pull request is currently in progress. Metricbeat Metricbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruflin @tsg @monicasarbu