Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

MCKIN-7030 Add student_view_data to PB Recap components #1040

Merged
merged 1 commit into from
Mar 31, 2018

Conversation

bradenmacdonald
Copy link

@e-kolpakov
Copy link

@bradenmacdonald There are a few quality violations (10 lines out of 100K lines) and some test failures - while they seem to be irrelevant to the change, I don't think it's a god idea if I just merge it now. Please consider my approval as "I'm ok with the change and don't think Ci failures are relevant", but please take a look yourself and consult with edx-solutions maintainers, if necessary.

Not merging just now.

@bradenmacdonald
Copy link
Author

@wajeeha-khalid Is someone from your team working on the test + quality failures on the rebased integration branch?

@wajeeha-khalid
Copy link

@bradenmacdonald We have not yet rebased platform but only Apros for now.
@ihtram from EdX is working on rebasing platform integration with master branch.
We will et you know once it is done.

@ihtram
Copy link

ihtram commented Mar 26, 2018

@bradenmacdonald The quality issues came after rebasing ginkgo. These issues will be resolved once we merge integration branch in master. I think it is okay to ignore quality failures and merge this branch.

@bradenmacdonald bradenmacdonald force-pushed the MCKIN-7030-student_view_data-recap branch from 1beb3d9 to 5877cbb Compare March 30, 2018 23:06
@bradenmacdonald
Copy link
Author

Ok, merging now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants