Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Update problem-builder version to include fix from 2.9.2 #1056

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

xitij2000
Copy link

Bump version of Problem Builder XBlock to v2.9.2 which adds description field in student_view_data for pb-answer-recap. Re: open-craft/problem-builder#185

Dependencies: open-craft/problem-builder#185

Reviewers

@openedx-webhooks
Copy link

Thanks for the pull request, @xitij2000! I've created OSPR-2370 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

If you like, you can add yourself to the AUTHORS file for this repo, though that isn't required. Please see the CONTRIBUTING file for more information.

@afzaledx
Copy link

@xitij2000 , the tests are failing because of a quality failure. Strange.

Total: 131600 lines
Violations: 2 lines
% Quality: 99%

Failure. Quality is below 100.0%.

@xitij2000
Copy link
Author

@afzaledx It seems those failures are currently expected. I don't feel comfortable merging this without running the tests though. So I think we should run them manually on our own system and if they pass we can merge this.
I will only be able to do this tomorrow though.

@xitij2000
Copy link
Author

@afzaledx I have run the tests manually on my system and the main tests are running fine. Do have a look and see if you have the same experience.

@xitij2000 xitij2000 merged commit 8aef022 into integration Apr 23, 2018
@xitij2000 xitij2000 deleted the kshitij/mckin-7030-update-pb-version branch April 23, 2018 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants